Author: lindner
Date: Mon Feb 20 03:36:49 2012
New Revision: 1291123
URL: http://svn.apache.org/viewvc?rev=1291123&view=rev
Log:
remove return type of removeResponseImpl to prepare for future Caching API
changes
Modified:
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultHttpCache.java
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/ProxyRendererTest.java
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitorTest.java
Modified:
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
URL:
http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java?rev=1291123&r1=1291122&r2=1291123&view=diff
==============================================================================
---
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
(original)
+++
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
Mon Feb 20 03:36:49 2012
@@ -89,7 +89,7 @@ public abstract class AbstractHttpCache
// Implement these methods to create a concrete HttpCache class.
protected abstract HttpResponse getResponseImpl(String key);
protected abstract void addResponseImpl(String key, HttpResponse response);
- protected abstract HttpResponse removeResponseImpl(String key);
+ protected abstract void removeResponseImpl(String key);
public HttpResponse getResponse(HttpRequest request) {
if (isCacheable(request)) {
Modified:
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultHttpCache.java
URL:
http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultHttpCache.java?rev=1291123&r1=1291122&r2=1291123&view=diff
==============================================================================
---
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultHttpCache.java
(original)
+++
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultHttpCache.java
Mon Feb 20 03:36:49 2012
@@ -49,7 +49,7 @@ public class DefaultHttpCache extends Ab
}
@Override
- protected HttpResponse removeResponseImpl(String key) {
- return cache.removeElement(key);
+ protected void removeResponseImpl(String key) {
+ cache.removeElement(key);
}
}
Modified:
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java
URL:
http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java?rev=1291123&r1=1291122&r2=1291123&view=diff
==============================================================================
---
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java
(original)
+++
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java
Mon Feb 20 03:36:49 2012
@@ -519,8 +519,8 @@ public class AbstractHttpCacheTest {
}
@Override
- public HttpResponse removeResponseImpl(String key) {
- return map.remove(key);
+ public void removeResponseImpl(String key) {
+ map.remove(key);
}
}
}
Modified:
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/ProxyRendererTest.java
URL:
http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/ProxyRendererTest.java?rev=1291123&r1=1291122&r2=1291123&view=diff
==============================================================================
---
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/ProxyRendererTest.java
(original)
+++
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/ProxyRendererTest.java
Mon Feb 20 03:36:49 2012
@@ -251,8 +251,8 @@ public class ProxyRendererTest {
}
@Override
- protected HttpResponse removeResponseImpl(String key) {
- return map.remove(key);
+ protected void removeResponseImpl(String key) {
+ map.remove(key);
}
}
Modified:
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitorTest.java
URL:
http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitorTest.java?rev=1291123&r1=1291122&r2=1291123&view=diff
==============================================================================
---
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitorTest.java
(original)
+++
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitorTest.java
Mon Feb 20 03:36:49 2012
@@ -253,8 +253,8 @@ public class CacheEnforcementVisitorTest
return map.get(key);
}
- public HttpResponse removeResponseImpl(String key) {
- return map.remove(key);
+ public void removeResponseImpl(String key) {
+ map.remove(key);
}
}