Author: ssievers
Date: Thu Apr 19 16:42:39 2012
New Revision: 1328043

URL: http://svn.apache.org/viewvc?rev=1328043&view=rev
Log:
SHINDIG-1749 | Common Container should log detailed error messages when a 
gadget fails to navigate or preload

Modified:
    
shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js
    shindig/trunk/features/src/main/javascript/features/container/container.js

Modified: 
shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js
URL: 
http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js?rev=1328043&r1=1328042&r2=1328043&view=diff
==============================================================================
--- 
shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js
 (original)
+++ 
shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js
 Thu Apr 19 16:42:39 2012
@@ -175,6 +175,9 @@ osapi.container.GadgetSite.prototype.nav
     if (gadgetInfo.error) {
       var message = ['Failed to navigate for gadget ', gadgetUrl, 
'.'].join('');
       gadgets.warn(message);
+
+      message = ['Detailed error: ', gadgetInfo.error.code || '', ' ', 
gadgetInfo.error.message || ''].join('');
+      gadgets.log(message);
     } else {
       var moduleId = renderParams[osapi.container.RenderParam.MODULE_ID] || 0;
       self.setModuleId_(gadgetUrl, moduleId, function() {

Modified: 
shindig/trunk/features/src/main/javascript/features/container/container.js
URL: 
http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/container.js?rev=1328043&r1=1328042&r2=1328043&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/container.js 
(original)
+++ shindig/trunk/features/src/main/javascript/features/container/container.js 
Thu Apr 19 16:42:39 2012
@@ -439,7 +439,11 @@ osapi.container.Container.prototype.init
 osapi.container.Container.prototype.addPreloadGadgets_ = function(response) {
   for (var id in response) {
     if (response[id].error) {
-      gadgets.warn(['Failed to preload gadget ', id, '.'].join(''));
+      var message = ['Failed to preload gadget ', id, '.'].join('');
+      gadgets.warn(message);
+
+      message = ['Detailed error: ', response[id].error.code || '', ' ', 
response[id].error.message || ''].join('');
+      gadgets.log(message);
     } else {
       this.addPreloadedGadgetUrl_(id);
       if (response[id][osapi.container.MetadataResponse.NEEDS_TOKEN_REFRESH]) {


Reply via email to