bmhm commented on a change in pull request #240:
URL: https://github.com/apache/shiro/pull/240#discussion_r440420468
##########
File path:
config/ogdl/src/main/java/org/apache/shiro/config/ogdl/ReflectionBuilder.java
##########
@@ -287,10 +287,15 @@ private String parseBeanId(String lhs) {
}
processor.execute();
- }
- //SHIRO-413: init method must be called for constructed objects that
are Initializable
- LifecycleUtils.init(objects.values());
+ //SHIRO-778: onInit method on AuthenticatingRealm is called twice
+ objects.keySet().stream()
+ .filter(key -> !kvPairs.keySet().contains(key))
Review comment:
I think it is not necessary to call `.keySet()` when you can just use
`.containsKey(key)`. This will create a new view each time, the latter might
also be a little bit easier to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
