bmhm commented on a change in pull request #252:
URL: https://github.com/apache/shiro/pull/252#discussion_r474204083
##########
File path:
support/spring/src/main/java/org/apache/shiro/spring/web/config/AbstractShiroWebConfiguration.java
##########
@@ -123,6 +131,19 @@ protected Cookie buildCookie(String name, int maxAge,
String path, String domain
cookie.setPath(path);
cookie.setDomain(domain);
cookie.setSecure(secure);
+ cookie.setSameSite(Cookie.SameSiteOptions.LAX);
Review comment:
I did't run the test because merging the ClassUtilsTest blocked mvn
compile… I was a bit quick. I'll add a cleanup commit first to the 1.6.x branch
(via PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
