ricardolsmendes edited a comment on pull request #255:
URL: https://github.com/apache/shiro/pull/255#issuecomment-682075540
Hi @bdemers!
I didn't face any issues after this change in my development environment.
I'm using other _Spring Boot Starters_ and get the following filters
registered:
```txt
2020-08-27 13:48:05.679 DEBUG 235 --- [ restartedMain]
o.s.b.w.s.ServletContextInitializerBeans : Mapping filters:
filterRegistrationBean urls=[/*] order=1, logoutFilter urls=[/security/logout]
order=2147483647, javamelody urls=[/*] order=2147483647, OCPsoft Rewrite Filter
urls=[/*] order=2147483647, characterEncodingFilter urls=[/*] order=-2147483648
```
(I suppressed some fillters from the actual log for security/readability
reasons...).
Just a final question: should we leverage this change to also set the filter
name? Adding something similar to `registrationBean.setName("shiroFilter");` to
`filterShiroFilterRegistrationBean()` would make it easier for users to
identify the Shiro Filter in debug logs. By doing this, the above output log
would become
```txt
2020-08-27 13:48:05.679 DEBUG 235 --- [ restartedMain]
o.s.b.w.s.ServletContextInitializerBeans : Mapping filters: shiroFilter
urls=[/*] order=1, logoutFilter urls=[/security/logout] order=2147483647,
javamelody urls=[/*] order=2147483647, OCPsoft Rewrite Filter urls=[/*]
order=2147483647, characterEncodingFilter urls=[/*] order=-2147483648
```
Please notice the change in the first filter name: `filterRegistrationBean`
to `shiroFilter`. WDYT? 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
