bdemers commented on a change in pull request #259:
URL: https://github.com/apache/shiro/pull/259#discussion_r505685698
##########
File path:
integration-tests/support/src/main/java/org/apache/shiro/testing/web/AbstractContainerIT.java
##########
@@ -109,6 +128,26 @@ protected WebAppContext createdWebAppContext() throws
Exception {
}
};
+ Server server = jetty.getDelegate();
+
+ // TLS
+ tlsPort = getFreePort();
+
+ final SslContextFactory sslContextFactory = new
SslContextFactory.Server();
+
sslContextFactory.setKeyStorePath(TEST_KEYSTORE_PATH.getAbsolutePath());
+ sslContextFactory.setKeyStorePassword(TEST_KEYSTORE_PASSWORD);
+ sslContextFactory.setKeyManagerPassword(TEST_KEYSTORE_PASSWORD);
+
+ HttpConfiguration https = new HttpConfiguration();
+ https.addCustomizer(new SecureRequestCustomizer());
+
+ final ServerConnector httpsConnector = new ServerConnector(
+ server,
+ new SslConnectionFactory(sslContextFactory,
HttpVersion.HTTP_1_1.asString()),
Review comment:
+💯
I gave it a quick try, but other jetty modules need to be included to
support http/2. That can be addressed in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
