cstamas commented on pull request #308:
URL: https://github.com/apache/shiro/pull/308#issuecomment-870709868
> Shouldn't the import for OSGI be modified as well?
@jherkel hm, now I realize I am wrong, it is currently
`<hazelcast.osgi.importRange>[3, 4)</hazelcast.osgi.importRange>` and see [1]
(sorry, am not OSGi guy).
So maybe my whole premise ("intent was to work with HZ 3 AND HZ4") is
completely wrong? As it may also mean that SHIRO-816 is a "non issue" actually
(should be closed as such: "Shiro 1.x Hazelcast support supports HZ3 only"),
given the module _was never intended_ to work with HZ4 in the first place?
As then, IMO proper solution is to
* drop this PR, close out issue SHIRO-816 ("not an issue: 1.x supports HZ3
only")
* Shiro 1.x is fine as is (will not work with HZ4, works with HZ3)
* in shiro to-be-2.0 introduce support for Hazelcast 4.x, drop support for
Hazelcast 3.x (could be this very same module but built against Hazelcast 4)
* done :smile:
[1]
https://www.eclipse.org/virgo/documentation/virgo-documentation-3.7.0.M01/docs/virgo-user-guide/html/ch02s02.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
