bmarwell commented on a change in pull request #269:
URL: https://github.com/apache/shiro/pull/269#discussion_r680729287
##########
File path: core/src/main/java/org/apache/shiro/session/Session.java
##########
@@ -149,7 +149,7 @@
* It is common for a {@code Subject} implementation to retain
authentication state in the
* {@code Session}. If the session
* is explicitly stopped by application code by calling this method
directly, it could clear out any
- * authentication state that might exist, thereby effectively
"unauthenticating" the {@code Subject}.
+ * authentication state that might exist, thereby effectively removing the
"authenticated" state of the {@code Subject}.
Review comment:
Not 100% sure about this one. I know "to unauthenticate" is not a common
word, but it is easier to understand than "removing the >authenticated<-state".
##########
File path:
core/src/main/java/org/apache/shiro/authc/pam/ModularRealmAuthenticator.java
##########
@@ -100,7 +100,7 @@ public ModularRealmAuthenticator() {
============================================*/
/**
- * Sets all realms used by this Authenticator, providing PAM (Pluggable
Authentication Module) configuration.
+ * Set al. realms used by this Authenticator, providing PAM (Pluggable
Authentication Module) configuration.
Review comment:
Thats a false positive
##########
File path: core/src/test/java/org/apache/shiro/realm/jdbc/JDBCRealmTest.java
##########
@@ -228,7 +228,7 @@ public void testExternalWrongPassword() throws Exception {
Subject.Builder builder = new Subject.Builder(securityManager);
Subject currentUser = builder.buildSubject();
- UsernamePasswordToken token = new UsernamePasswordToken(username,
"passwrd");
+ UsernamePasswordToken token = new UsernamePasswordToken(username,
"password");
Review comment:
no, test
##########
File path: core/src/test/java/org/apache/shiro/realm/jdbc/JDBCRealmTest.java
##########
@@ -112,7 +112,7 @@ public void testUnSaltedWrongPassword() throws Exception {
Subject.Builder builder = new Subject.Builder(securityManager);
Subject currentUser = builder.buildSubject();
- UsernamePasswordToken token = new UsernamePasswordToken(username,
"passwrd");
+ UsernamePasswordToken token = new UsernamePasswordToken(username,
"password");
Review comment:
no, test
##########
File path: core/src/test/java/org/apache/shiro/realm/jdbc/JDBCRealmTest.java
##########
@@ -179,7 +179,7 @@ public void testSaltColumnWrongPassword() throws Exception {
Subject.Builder builder = new Subject.Builder(securityManager);
Subject currentUser = builder.buildSubject();
- UsernamePasswordToken token = new UsernamePasswordToken(username,
"passwrd");
+ UsernamePasswordToken token = new UsernamePasswordToken(username,
"password");
Review comment:
no, test
##########
File path: core/src/test/java/org/apache/shiro/realm/jdbc/JDBCRealmTest.java
##########
@@ -197,7 +197,7 @@ public void testBase64SaltColumnWrongPassword() throws
Exception {
Subject.Builder builder = new Subject.Builder(securityManager);
Subject currentUser = builder.buildSubject();
- UsernamePasswordToken token = new UsernamePasswordToken(username,
"passwrd");
+ UsernamePasswordToken token = new UsernamePasswordToken(username,
"password");
Review comment:
no, test
##########
File path: core/src/test/java/org/apache/shiro/realm/jdbc/JDBCRealmTest.java
##########
@@ -132,7 +132,7 @@ public void testUnSaltedMultipleRows() throws Exception {
Subject.Builder builder = new Subject.Builder(securityManager);
Subject currentUser = builder.buildSubject();
- UsernamePasswordToken token = new UsernamePasswordToken(username,
"passwrd");
+ UsernamePasswordToken token = new UsernamePasswordToken(username,
"password");
Review comment:
no, test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
