sebastianfrey commented on code in PR #369:
URL: https://github.com/apache/shiro/pull/369#discussion_r933807562


##########
web/src/main/java/org/apache/shiro/web/util/WebUtils.java:
##########
@@ -616,7 +616,20 @@ public static boolean isTrue(ServletRequest request, 
String paramName) {
      * @return the clean param value, or null if the param does not exist or 
is empty.
      */
     public static String getCleanParam(ServletRequest request, String 
paramName) {
-        return StringUtils.clean(request.getParameter(paramName));
+        return getCleanParam(request, paramName, true);
+    }
+
+    /**
+     * Convenience method that returns a request parameter value, first 
running it through
+     * {@link StringUtils#clean(String)}.
+     *
+     * @param request   the servlet request.
+     * @param paramName the parameter name.
+     * @param trim specifies whether the parameter value shoudl be trimmed or 
not

Review Comment:
   Typo `shoudl`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to