lprimak commented on PR #1059: URL: https://github.com/apache/shiro/pull/1059#issuecomment-1712564168
First of all, great job, thanks! I have fixed up the configuration for the most part to the way it was. However, some major and minor issues remain Some minor issues: - Line endings. Looks like you have windows line endings in your source code. This repo uses unix line endings. Can you fix that? Major issues: - Tests and demos need to be included in checkstyle checking - There are too many changes in checkstyle configuration. Most things should be done inline using `@SuppressWarnings` and not in configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
