ksilisk opened a new pull request, #1193:
URL: https://github.com/apache/shiro/pull/1193

   When using the utility, I noticed that the logs were displayed incorrectly. 
   I found a similar problem in Jira, but I think the `[INFO ]` output is 
correct, but the space after it is a consequence of incorrect logger settings, 
which I corrected.
   Also update log message.
   
   <!--
   For Security Vulnerabilities, please email: [email protected]
   For more details on how to report a vulnerablity see: 
https://www.apache.org/security/
   -->
   
   Following this checklist to help us incorporate your contribution quickly 
and easily:
   
    - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SHIRO) filed
   for the change (usually before you start working on it). Trivial changes 
like typos do not
   require a JIRA issue. Your pull request should address just this issue, 
without pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [x] Format the pull request title like `[SHIRO-XXX] - Fixes bug in 
SessionManager`,
   where you replace `SHIRO-XXX` with the appropriate JIRA issue. Best practice
   is to use the JIRA issue title in the pull request title and in the first 
line of the commit message.
    - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [x] Run `mvn verify` to make sure basic checks pass. A more thorough 
check will be performed on your pull request automatically.
    - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`. 
    - [ ] Committers: Make sure a milestone is set on the PR
    
   Trivial changes like typos do not require a GitHub issue (javadoc, 
comments...). 
   In this case, just format the pull request title like `[DOC] - Add javadoc 
in SessionManager`.
    
   If this is your first contribution, you have to read the [Contribution 
Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
   
   If your pull request is about ~20 lines of code you don't need to sign an 
[Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) 
   if you are unsure please ask on the developers list.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
    - [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to