timtebeek opened a new pull request, #1338:
URL: https://github.com/apache/shiro/pull/1338
Following this checklist to help us incorporate your contribution quickly
and easily:
- [x] Make sure there is a [GitHub
issue](https://github.com/apache/shiro/issues) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a GitHub issue. Your pull request should address just this
issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[#XXX] - Fixes bug in
SessionManager`,
where you replace `#XXX` with the appropriate GitHub issue. Best
practice
is to use the GitHub issue title in the pull request title and in the
first line of the commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] add `fixes #XXX` if merging the PR should close a related issue.
- [x] Run `mvn verify` to make sure basic checks pass. A more thorough
check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Committers: Make sure a milestone is set on the PR
Trivial changes like typos do not require a GitHub issue (javadoc,
comments...).
In this case, just format the pull request title like `[DOC] - Add javadoc
in SessionManager`.
If this is your first contribution, you have to read the [Contribution
Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Hi! Noticed that the JUnit 5 migration had missed a few small steps to
optimize the methods called, and sometimes swap the argument order. The
compiler won't complain about such issues, but it's best to conform to JUnit
5's best practices. Hope this is helpful! It's a mostly automated change,
prompted by the summons here:
https://twitter.com/lobaorn/status/1763676683012317411
Tagging @bmarwell for review, since he opened
- https://github.com/apache/shiro/pull/237
Use this link to re-run the recipe:
https://app.moderne.io/recipes/builder/hBA8IygoJ?
organizationId=YzQ4NzM2ZmItNmRjOS00ZmU2LWJhOTUtNDQ4NTViYTRhNWFk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
