timtebeek commented on code in PR #1450:
URL: https://github.com/apache/shiro/pull/1450#discussion_r1588037969
##########
integration-tests/jakarta-ee/src/test/java/org/apache/shiro/testing/cdi/ComponentInjectionIT.java:
##########
@@ -20,6 +20,7 @@
import org.apache.shiro.authc.UsernamePasswordToken;
import static org.apache.shiro.ee.util.JakartaTransformer.jakartify;
+import static org.assertj.core.api.Assertions.assertThat;
Review Comment:
This seems to have brought on an error in the tests, despite there being a
transitive assertj dependency.
```
[INFO] Running org.apache.shiro.testing.cdi.ComponentInjectionIT
Error: Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed:
16.51 s <<< FAILURE! -- in org.apache.shiro.testing.cdi.ComponentInjectionIT
Error: org.apache.shiro.testing.cdi.ComponentInjectionIT.principalInjection
-- Time elapsed: 0.407 s <<< ERROR!
java.lang.NoClassDefFoundError: org/assertj/core/api/Assertions
at
org.apache.shiro.testing.cdi.ComponentInjectionIT.principalInjection(ComponentInjectionIT.java:107)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.jboss.arquillian.junit5.ArquillianExtension.interceptTestMethod(ArquillianExtension.java:87)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
Caused by: java.lang.ClassNotFoundException: org.assertj.core.api.Assertions
at
org.glassfish.web.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1821)
at
org.glassfish.web.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1662)
... 5 more
```
How would we want to see this resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
