bmarwell commented on PR #1454:
URL: https://github.com/apache/shiro/pull/1454#issuecomment-2094038093

   > I think the problem can be this one about api change:
   > 
   >     public void setEnvironment(Map<String, Object> env) {
   > 
   > For now user can put any type in the key and we can imagine that he should 
use a String but we are not sure.
   > 
   > I understand the purpose of the best practice but it's not a good idea to 
update our api because of unit test framework change.
   
   Yes, that's a real no go and needs to wait until 3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to