lprimak commented on PR #2066:
URL: https://github.com/apache/shiro/pull/2066#issuecomment-2780201145
Hi,
A quick look at this PR, and it doesn't really seem to fix an actual problem.
The only time `principal` is used is when checking `instanceof`: `if
(principal instanceof String) {`
So if it's `null`, then this check would not pass.
Do you have a test that actually produces `NullPointerException` prior to
this PR?
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
