lprimak commented on code in PR #2082:
URL: https://github.com/apache/shiro/pull/2082#discussion_r2042382382
##########
core/src/main/java/org/apache/shiro/util/ThreadContext.java:
##########
@@ -327,26 +327,5 @@ public static void bind(Subject subject) {
public static Subject unbindSubject() {
return (Subject) remove(SUBJECT_KEY);
}
-
- private static final class InheritableThreadLocalMap<T extends Map<Object,
Object>>
- extends
InheritableThreadLocal<Map<Object, Object>> {
-
- /**
- * This implementation was added to address a
- * <a
href="http://jsecurity.markmail.org/search/?q=#query:+page:1+mid:xqi2yxurwmrpqrvj+state:results";>
- * user-reported issue</a>.
Review Comment:
This was a bug with the `InheriableThreadLocalMap` implementation, it needed
to do a deep copy of the map. Since it's no longer Inheritable, the issue above
no longer applies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
