AetherRadar opened a new pull request, #2088: URL: https://github.com/apache/shiro/pull/2088
## Issue Description Found a redundant Optional check in DefaultHashService class. The current implementation checks if Optional is present (isPresent()) before accessing its value, which is unnecessary as the subsequent method already safely handles null values. ## Changes Made - Removed redundant isPresent() check in DefaultHashService - Simplified code flow while maintaining the same functionality ## Rationale This change improves code readability by avoiding unnecessary conditional checks without changing the behavior. Redundant Optional checks make the code more complex and potentially misleading. ## Testing Ran `mvn verify` to ensure basic checks pass. This change does not affect existing functionality, and all tests continue to pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
