rgcv commented on code in PR #2018: URL: https://github.com/apache/shiro/pull/2018#discussion_r2259401822
########## support/cdi/src/main/resources/META-INF/beans.xml: ########## @@ -17,8 +17,7 @@ ~ specific language governing permissions and limitations ~ under the License. --> -<beans xmlns="http://xmlns.jcp.org/xml/ns/javaee"; +<beans xmlns="https://jakarta.ee/xml/ns/jakartaee"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/beans_2_0.xsd"; - bean-discovery-mode="annotated"> + xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartae/beans_4_0.xsd";> Review Comment: ```suggestion xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/beans_4_0.xsd";> ``` ########## samples/web-jakarta/src/main/webapp/WEB-INF/web.xml: ########## @@ -17,10 +17,10 @@ ~ specific language governing permissions and limitations ~ under the License. --> -<web-app xmlns="http://xmlns.jcp.org/xml/ns/javaee"; +<web-app xmlns="https://jakarta.ee/xml/ns/jakartaee"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_4_0.xsd"; - version="4.0"> + xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartae/web-app_6_0.xsd"; Review Comment: ```suggestion xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-app_6_0.xsd"; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
