nsoft commented on PR #2017: URL: https://github.com/apache/shiro/pull/2017#issuecomment-3215639331
I had never heard of OpenRewrite until after I submitted this PR. I went through and fixed things till they compiled, and then repeated the process with the tests until they passed. Took me about a solid week. The sad reality is that the mess caused by Oracle giving this stuff away but not relinquishing the namespace is tremendous. Many many projects have struggled with it. Apache Solr also still hasn't entirely expunged javax, though 10.x when it's released will at least get rid of the stuff that was inherited directly from Jetty (jetty version will move to 12 there. I have a minor dream (of the sort that I will probably never find time for) of implementing a shiro based auth plugin for Solr, but now that Solr is moving forward, probably this PR or something like it would be required. I doubt re-doing this with open-rewrite is really going to produce anything simpler, You'll really just wind up with 2 huge things to review and compare instead of one thing to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
