jbampton opened a new pull request, #2337: URL: https://github.com/apache/shiro/pull/2337
<!-- For Security Vulnerabilities, please email: [email protected] For more details on how to report a vulnerability see: https://www.apache.org/security/ --> Tested here locally with `pre-commit run --all-files` First time the oxipng hook failed and optimized the PNGs. <img width="1310" height="468" alt="Screenshot from 2025-10-25 15-45-08" src="https://github.com/user-attachments/assets/9c99bc6f-6e2f-4568-8271-d55dbc677d75"; /> The second time the hook passed. With GitHub actions it just works with pass and fail. https://github.com/oxipng/oxipng "Lossless compression reduces file size without losing any information, allowing the original data to be perfectly reconstructed upon decompression. It works by identifying and eliminating statistical redundancy in the data, making it ideal for situations where data integrity is critical, such as with text, charts, or raw images. Popular examples include the PNG and ZIP formats." https://en.wikipedia.org/wiki/Lossless_compression Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [GitHub issue](https://github.com/apache/shiro/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[#XXX] - Fixes bug in SessionManager`, where you replace `#XXX` with the appropriate GitHub issue. Best practice is to use the GitHub issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] add `fixes #XXX` if merging the PR should close a related issue. - [ ] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Committers: Make sure a milestone is set on the PR Trivial changes like typos do not require a GitHub issue (javadoc, comments...). In this case, just format the pull request title like `[DOC] - Add javadoc in SessionManager`. If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md) If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
