lprimak commented on code in PR #2327:
URL: https://github.com/apache/shiro/pull/2327#discussion_r2463006515
##########
crypto/support/hashes/bcrypt/src/main/java/org/apache/shiro/crypto/support/hashes/bcrypt/BCryptHash.java:
##########
@@ -166,7 +176,7 @@ public String formatToCryptString() {
String dataBase64 = new String(bsdBase64.encode(this.getBytes()),
StandardCharsets.ISO_8859_1);
return new StringJoiner("$", "$", "")
- .add(this.getAlgorithmName())
+ .add(getBcryptVersion(this.getAlgorithmName()))
Review Comment:
Since the "version" is the "official" algorithm name, i.e. the name stored
in the password file,
and the longer one is an alias (or the other way around?) the naming
convention seems correct.
I don't see how this can really be aligned further without encroaching on
the "veto" :)
However, I am open to ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
