This is an automated email from the ASF dual-hosted git repository.
lprimak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/shiro.git
The following commit(s) were added to refs/heads/main by this push:
new 716f038e8 chore: fixed discussions notification target in .asf.yaml
and syncd pull request template since "squash and merge" is enabled
716f038e8 is described below
commit 716f038e89610463230180aa8bb291f30420884c
Author: lprimak <[email protected]>
AuthorDate: Thu Dec 4 22:40:54 2025 -0600
chore: fixed discussions notification target in .asf.yaml and syncd pull
request template since "squash and merge" is enabled
---
.asf.yaml | 1 +
.github/pull_request_template.md | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.asf.yaml b/.asf.yaml
index 42c61cb86..419997d54 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -34,4 +34,5 @@ notifications:
pullrequests: [email protected]
commits: [email protected]
issues: [email protected]
+ discussions: [email protected]
jira_options: link label worklog
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 4c5f1252f..0d4856dac 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -8,15 +8,14 @@ Following this checklist to help us incorporate your
contribution quickly and ea
- [ ] Make sure there is a [GitHub
issue](https://github.com/apache/shiro/issues) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a GitHub issue. Your pull request should address just this
issue, without pulling in other changes.
- - [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[#XXX] - Fixes bug in
SessionManager`,
where you replace `#XXX` with the appropriate GitHub issue. Best
practice
is to use the GitHub issue title in the pull request title and in the
first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] add `fixes #XXX` if merging the PR should close a related issue.
- [ ] Run `mvn verify` to make sure basic checks pass. A more thorough check
will be performed on your pull request automatically.
- - [ ] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Committers: Make sure a milestone is set on the PR
+ - [ ] Committers: Use "Squash and Merge" to combine all commits into one when
merging a PR when appropriate.
Trivial changes like typos do not require a GitHub issue (javadoc,
comments...).
In this case, just format the pull request title like `[DOC] - Add javadoc in
SessionManager`.
