steinarb commented on PR #2712: URL: https://github.com/apache/shiro/pull/2712#issuecomment-4535080282
>>>>> Lenny Primak ***@***.***>: > lprimak left a comment (apache/shiro#2712) > I've decided to continue with current approach, Steinar, > Which test do you think is missing? Will be glad to add. > We have `org/apache/shiro/session/mgt/SimpleSessionTest.java`, > also we have `org/apache/shiro/session/mgt/AbstractValidatingSessionManagerTest.java` Ah, sorry. For some reason I thought this was a new class. Mental short circuit. If SimpleSessiontest covers everything then of course no new tests are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
