xaccefy commented on PR #2836: URL: https://github.com/apache/shiro/pull/2836#issuecomment-5292077902
Thanks for the review! All points addressed: - Reverted the catch-all fallback in `PathMatchingFilterChainResolver` — agreed it is unreachable now that `getPathWithinApplication()` throws; the file is back to upstream. - Restructured `getPathWithinApplication()` per your comments: happy path unchanged, check is now `path == null || path.isEmpty()`, and the path components for the exception message are only re-read inside the throw branch. - Re: `SimpleFilterChainResolver` (guice) — it calls `WebUtils.getPathWithinApplication()` directly, so it is covered by the same throw; no change needed there. - Renamed issue #2837 and this PR to match the actual problem, rewrote both descriptions, and filled out the restored template. `mvn verify` (scoped to web + its dependencies, RAT/checkstyle/javadoc included) passes. Ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
