lprimak commented on code in PR #2857:
URL: https://github.com/apache/shiro/pull/2857#discussion_r3789436888
##########
core/src/main/java/org/apache/shiro/util/AntPathMatcher.java:
##########
@@ -157,8 +157,7 @@ protected boolean doMatch(String pattern, String path,
boolean fullMatch) {
if (pathIdxStart > pathIdxEnd) {
// Path is exhausted, only match if rest of pattern is * or **'s
if (pattIdxStart > pattIdxEnd) {
- return (pattern.endsWith(this.pathSeparator)
- ? path.endsWith(this.pathSeparator) :
!path.endsWith(this.pathSeparator));
+ return (pattern.endsWith(this.pathSeparator) ==
path.endsWith(this.pathSeparator));
Review Comment:
Yes... My tooling (Sonar) checks all the code I touch, so I fix it to leave
it better than I found it.
All of these are mostly style changes with no functional changes.
I hope that's ok... if not, I can revert them. Let me know, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
