lprimak commented on code in PR #2859:
URL: https://github.com/apache/shiro/pull/2859#discussion_r3790312343
##########
core/src/main/java/org/apache/shiro/subject/SubjectContext.java:
##########
@@ -235,4 +235,17 @@ public interface SubjectContext extends Map<String,
Object> {
void setHost(String host);
String resolveHost();
+
+ /**
+ * Sets whether the constructed {@code Subject} instance should was
constructed from remembered principals
+ */
+ default void setRememberedPrincipals(boolean rememberedPrincipals) { }
Review Comment:
Yes. The issue is you cannot just add methods to interfaces without breaking
compatibility.
They need to have default implementation (empty here)
This is implemented in `DefaultSubjectContext`
Actually, these should throw an exception. I will make it so.
Thanks for the hint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
