Author: desruisseaux
Date: Sat Dec 15 10:40:15 2012
New Revision: 1422217
URL: http://svn.apache.org/viewvc?rev=1422217&view=rev
Log:
IP review for DirectPosition2D.
Added:
sis/ip-review/DirectPosition2D.xhtml (with props)
sis/ip-review/rev/10796/DirectPosition2D.xhtml (with props)
sis/ip-review/rev/20874/DirectPosition2D.xhtml (with props)
sis/ip-review/rev/24925/DirectPosition2D.xhtml (with props)
Added: sis/ip-review/DirectPosition2D.xhtml
URL:
http://svn.apache.org/viewvc/sis/ip-review/DirectPosition2D.xhtml?rev=1422217&view=auto
==============================================================================
--- sis/ip-review/DirectPosition2D.xhtml (added)
+++ sis/ip-review/DirectPosition2D.xhtml Sat Dec 15 10:40:15 2012
@@ -0,0 +1,63 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+ <head>
+ <meta charset="UTF-8"/>
+ <title>DirectPosition2D history</title>
+ <style type="text/css" media="all">
+ @import url("./reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>DirectPosition2D history</h1>
+ <p>Click on the commit message for inspecting the <code>diff</code> and how
the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/DirectPosition2D.java</code></blockquote>
+<table>
+ <tr>
+ <th>Rev.</th>
+ <th>Date</th>
+ <th>Author</th>
+ <th class="last">Message</th>
+ </tr>
+<tr><td
class="rev">30892</td><td>2008-07-04</td><td>desruisseaux</td><td>Compatible
GeoAPI change: DirectPosition.getCoordinates() made singular
(GEO-135).</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in
Toolkit)</td></tr>
+<tr><td
class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update
referencing headers</td></tr>
+<tr><td
class="rev">30497</td><td>2008-06-03</td><td>desruisseaux</td><td>Renamed
Position.getPosition() as getDirectPosition() in GeoAPI interface for avoiding
ambiguity (GEO-87). Javadoc fixes.</td></tr>
+<tr><td
class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my
mind about Utilities.shallowEquals(Object,Object) and renamed it as equals,
since a few tests show that the compiler always select the best overloaded
flavor working on primitive types (except if an argument is a boolean and the
other a different primitive type). Updated a few references. Fixed a few
javadoc warnings by explicit declaration of parameter and return
values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the
(at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td
class="rev">28790</td><td>2008-01-16</td><td>desruisseaux</td><td>Renamed
resources.i18n.Logging as resources.i18n.Loggings (with an s) for avoiding name
clash with util.logging.Logging. The name clash would not have been an issue if
those two classes were not typically used together... Also performed a few
javadoc fixes in DirectPosition2D.</td></tr>
+<tr><td class="rev">28779</td><td>2008-01-16</td><td>desruisseaux</td><td>In
referencing module, changed the DirectPosition2D.hashCode() and equals(Object)
implementation in order to comply with DirectPosition contract, which fix an
AssertionError. It has the unfortunate side-effect of violating the
Point2D.hashCode() contract. Unfortunatly it is not possible to comply to both
in same time. I added a note in javadoc trying to make that clear.In the
coverage module, applied the ImageWorker changes mentioned on the mailing list.
Also provided a first draft of an ImageWorkerTest. Note that the build still
fail in the shapefile-renderer module for a reason that I believe unrelated to
those changes. The same changes have already been applied to the 2.4 branch,
which build fine.</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td
class="rev">28500</td><td>2007-12-24</td><td>desruisseaux</td><td>Added a new
GridGeometry implementation (ImageGeometry) has a lightweight placeholder for
'gridRange' as a Rectangle and 'gridToCRS' as an AffineTransform. Used by
TileBuilder.</td></tr>
+<tr><td
class="rev">28267</td><td>2007-12-06</td><td>desruisseaux</td><td>GeoTools
trunk now build against GeoAPI 2.2-SNAPSHOT.</td></tr>
+<tr><td
class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td
class="rev">26137</td><td>2007-07-03</td><td>desruisseaux</td><td>Image I/O
GeographicMetadata should now supports read and write operations for most
attributes. More tests needed.</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td
class="unav">jgarnett</td><td><a href="rev/24925/DirectPosition2D.xhtml">change
to org.opengis.geometry</a></td></tr>
+<tr><td
class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common
directory.</td></tr>
+<tr><td
class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to
'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td
class="unav">jgarnett</td><td><a href="rev/20874/DirectPosition2D.xhtml">ip
review</a></td></tr>
+<tr><td
class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source
tag.</td></tr>
+<tr><td
class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN
attributes, including the addition of URL attribute.</td></tr>
+<tr><td
class="rev">17460</td><td>2006-01-05</td><td>desruisseaux</td><td>Added support
classes for GO-1 implementation. Partial Maven 2 fixes for the new
module/renderer module.</td></tr>
+<tr><td
class="rev">16172</td><td>2005-10-10</td><td>desruisseaux</td><td>Moved a JTS
dependency from the CRS class to the JTS class (GEOT-716)</td></tr>
+<tr><td
class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the
'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td
class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of
referencing module from main</td></tr>
+<tr><td
class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare
branch for splitting main</td></tr>
+<tr><td
class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since
javadoc tag</td></tr>
+<tr><td
class="rev">13046</td><td>2005-04-10</td><td>desruisseaux</td><td>First "should
be working" (translation: "not yet tested") version of CoverageStack.</td></tr>
+<tr><td
class="rev">11960</td><td>2005-03-10</td><td>desruisseaux</td><td>First draft
of GridCoverage 'resampler' operation port</td></tr>
+<tr><td
class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong
encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td
class="unav">dzwiers</td><td><a href="rev/10796/DirectPosition2D.xhtml">imports
cleaned</a></td></tr>
+<tr><td
class="rev">10167</td><td>2005-01-02</td><td>desruisseaux</td><td>Improved
console: added distance computation</td></tr>
+<tr><td
class="rev">8796</td><td>2004-10-22</td><td>desruisseaux</td><td>Cleaning
referencing's operation basic package</td></tr>
+<tr><td class="rev">6536</td><td>2004-06-25</td><td>desruisseaux</td><td>Added
SingleCRS class / Renamed ObliqueCartesianCS as AffineCS / Moved Position as
super-interface for DirectPosition and Point</td></tr>
+<tr><td
class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS
implementation</td></tr>
+<tr><td class="rev">6148</td><td>2004-05-25</td><td>desruisseaux</td><td>Moved
org.geotools.io.NIOBufferUtils to org.geotools.resources.NIOUtilities</td></tr>
+<tr><td
class="rev">6098</td><td>2004-05-23</td><td>desruisseaux</td><td>Partial
implementation of GeoAPI referencing package</td></tr>
+</table>
+ </div>
+ </body>
+</html>
Propchange: sis/ip-review/DirectPosition2D.xhtml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: sis/ip-review/DirectPosition2D.xhtml
------------------------------------------------------------------------------
svn:mime-type = text/html
Added: sis/ip-review/rev/10796/DirectPosition2D.xhtml
URL:
http://svn.apache.org/viewvc/sis/ip-review/rev/10796/DirectPosition2D.xhtml?rev=1422217&view=auto
==============================================================================
--- sis/ip-review/rev/10796/DirectPosition2D.xhtml (added)
+++ sis/ip-review/rev/10796/DirectPosition2D.xhtml Sat Dec 15 10:40:15 2012
@@ -0,0 +1,61 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+ <head>
+ <meta charset="UTF-8"/>
+ <title>DirectPosition2D changes for revisions 10795:10796</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>DirectPosition2D changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto
reformat</cite>" tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import
ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters
is broken.
+This commit has been reverted, except for the removal of really unused imports
which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change
--ignore-all-space --ignore-eol-style" -r10795:10796
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/DirectPosition2D.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2004, Institut de Recherche pour le
Développement</span>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2004, Institut de Recherche pour le
D�veloppement</span>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General
Public</pre></td></tr>
+<tr><td><pre>// J2SE dependencies
+import java.awt.geom.Point2D;
+<span class="del">import java.io.Serializable;</span>
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.referencing.cs.AxisDirection; // For
javadoc</span>
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+import org.opengis.spatialschema.geometry.DirectPosition;
+import
org.opengis.spatialschema.geometry.MismatchedDimensionException;</pre></td>
+<td><pre>// J2SE dependencies
+import java.awt.geom.Point2D;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+<span class="add">import java.io.Serializable;</span>
+
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+<span class="add">import org.opengis.referencing.cs.AxisDirection;</span>
+import org.opengis.spatialschema.geometry.DirectPosition;
+import
org.opengis.spatialschema.geometry.MismatchedDimensionException;</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Propchange: sis/ip-review/rev/10796/DirectPosition2D.xhtml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: sis/ip-review/rev/10796/DirectPosition2D.xhtml
------------------------------------------------------------------------------
svn:mime-type = text/html
Added: sis/ip-review/rev/20874/DirectPosition2D.xhtml
URL:
http://svn.apache.org/viewvc/sis/ip-review/rev/20874/DirectPosition2D.xhtml?rev=1422217&view=auto
==============================================================================
--- sis/ip-review/rev/20874/DirectPosition2D.xhtml (added)
+++ sis/ip-review/rev/20874/DirectPosition2D.xhtml Sat Dec 15 10:40:15 2012
@@ -0,0 +1,60 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+ <head>
+ <meta charset="UTF-8"/>
+ <title>DirectPosition2D changes for revisions 20873:20874</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>DirectPosition2D changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your
option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer
other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions
are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change
--ignore-all-space --ignore-eol-style" -r20873:20874
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/DirectPosition2D.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee
(PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+<span class="del"> * License as published by the Free Software Foundation;
either</span>
+<span class="del"> * version 2.1 of the License, or (at your option) any
later version.</span>
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> * You should have received a copy of the GNU Lesser
General Public</span>
+<span class="del"> * License along with this library; if not, write to the
Free Software</span>
+<span class="del"> * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
MA 02111-1307 USA</span>
+ */
+package org.geotools.geometry;</pre></td>
+<td><pre>/*
+<span class="add"> * GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> * http://geotools.org</span>
+<span class="add"> * (C) 2004-2006, GeoTools Project Managment Committee
(PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+<span class="add"> * License as published by the Free Software
Foundation;</span>
+<span class="add"> * version 2.1 of the License.</span>
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ */
+package org.geotools.geometry;</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Propchange: sis/ip-review/rev/20874/DirectPosition2D.xhtml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: sis/ip-review/rev/20874/DirectPosition2D.xhtml
------------------------------------------------------------------------------
svn:mime-type = text/html
Added: sis/ip-review/rev/24925/DirectPosition2D.xhtml
URL:
http://svn.apache.org/viewvc/sis/ip-review/rev/24925/DirectPosition2D.xhtml?rev=1422217&view=auto
==============================================================================
--- sis/ip-review/rev/24925/DirectPosition2D.xhtml (added)
+++ sis/ip-review/rev/24925/DirectPosition2D.xhtml Sat Dec 15 10:40:15 2012
@@ -0,0 +1,51 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+ <head>
+ <meta charset="UTF-8"/>
+ <title>DirectPosition2D changes for revisions 24924:24925</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>DirectPosition2D changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change
--ignore-all-space --ignore-eol-style" -r24924:24925
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/DirectPosition2D.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>// OpenGIS dependencies
+import org.opengis.referencing.cs.AxisDirection; // For javadoc
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+<span class="del">import
org.opengis.spatialschema.geometry.DirectPosition;</span>
+<span class="del">import
org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+
+
+/**</pre></td>
+<td><pre>// OpenGIS dependencies
+import org.opengis.referencing.cs.AxisDirection; // For javadoc
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+<span class="add">import org.opengis.geometry.DirectPosition;</span>
+<span class="add">import
org.opengis.geometry.MismatchedDimensionException;</span>
+
+
+/**</pre></td></tr>
+<tr><td><pre>/**
+ * Returns always <code>this</code>, the direct position for this
+<span class="del"> * {@linkplain
org.opengis.spatialschema.geometry.geometry.Position position}.</span>
+ */
+public DirectPosition getPosition() {
+ return this;</pre></td>
+<td><pre>/**
+ * Returns always <code>this</code>, the direct position for this
+<span class="add"> * {@linkplain org.opengis.geometry.coordinate.Position
position}.</span>
+ */
+public DirectPosition getPosition() {
+ return this;</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Propchange: sis/ip-review/rev/24925/DirectPosition2D.xhtml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: sis/ip-review/rev/24925/DirectPosition2D.xhtml
------------------------------------------------------------------------------
svn:mime-type = text/html
