Author: desruisseaux
Date: Sun Dec 16 07:40:44 2012
New Revision: 1422478

URL: http://svn.apache.org/viewvc?rev=1422478&view=rev
Log:
Added IP-review for AbstractEnvelope and GeneralEnvelope.

Added:
    sis/ip-review/AbstractEnvelope.xhtml   (with props)
    sis/ip-review/GeneralEnvelope.xhtml   (with props)
    sis/ip-review/rev/10796/AbstractEnvelope.xhtml   (with props)
    sis/ip-review/rev/20874/AbstractEnvelope.xhtml   (with props)
    sis/ip-review/rev/24116/
    sis/ip-review/rev/24116/AbstractEnvelope.xhtml   (with props)
    sis/ip-review/rev/24116/HEADER.html   (with props)
    sis/ip-review/rev/24485/
    sis/ip-review/rev/24485/AbstractEnvelope.xhtml   (with props)
    sis/ip-review/rev/24485/HEADER.html   (with props)
    sis/ip-review/rev/25001/
    sis/ip-review/rev/25001/AbstractEnvelope.xhtml   (with props)
    sis/ip-review/rev/25001/HEADER.html   (with props)

Added: sis/ip-review/AbstractEnvelope.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/AbstractEnvelope.xhtml?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/AbstractEnvelope.xhtml (added)
+++ sis/ip-review/AbstractEnvelope.xhtml Sun Dec 16 07:40:44 2012
@@ -0,0 +1,83 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractEnvelope history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractEnvelope history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how 
the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractEnvelope.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td 
class="rev">30892</td><td>2008-07-04</td><td>desruisseaux</td><td>Compatible 
GeoAPI change: DirectPosition.getCoordinates() made singular 
(GEO-135).</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright 
headers: lib/referencing, this time with feeling (and the el in 
Toolkit)</td></tr>
+<tr><td 
class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update 
referencing headers</td></tr>
+<tr><td 
class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my 
mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, 
since a few tests show that the compiler always select the best overloaded 
flavor working on primitive types (except if an argument is a boolean and the 
other a different primitive type). Updated a few references. Fixed a few 
javadoc warnings by explicit declaration of parameter and return 
values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle 
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move 
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td 
class="rev">29092</td><td>2008-02-05</td><td>desruisseaux</td><td>Documentation 
updates. Java 5 type safety mostly in EPSG factories. LogarithmicTransform1D 
optimization by using the new (and presumably more accurate) Java 5 
Math.log10(double) method.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the 
(at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide 
buttons which are not yet used</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More 
MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name 
in a separated utilities class named 'Classes'. Also added a couple of 
@Override annotations.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid 
unecessary synchronisation; rely on auto-boxing in order to give a chance to 
the JVM to reuse its cached values.</td></tr>
+<tr><td 
class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted 
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td 
class="rev">26137</td><td>2007-07-03</td><td>desruisseaux</td><td>Image I/O 
GeographicMetadata should now supports read and write operations for most 
attributes. More tests needed.</td></tr>
+<tr><td 
class="rev">25779</td><td>2007-06-08</td><td>desruisseaux</td><td>Added 
CRS.transform(CoordinateOperation, ...) methods, which are able to handle the 
special cases where the source envelope contains a singularity like a pole or 
the 180� longitude. As a side effect, changed Envelope.toString() to a more 
straightforward formatting, easier for debugging.</td></tr>
+<tr><td class="rev">25001</td><td>2007-04-03</td><td 
class="unav">chorner</td><td><a 
href="rev/25001/AbstractEnvelope.xhtml">switched back to geoapi 2.1-SNAPSHOT; 
reverted GeographicBoundingBox</a></td></tr>
+<tr><td class="rev">24973</td><td>2007-03-30</td><td 
class="unav">chorner</td><td><a href="rev/25001/AbstractEnvelope.xhtml">GEO-93: 
GeoTools/GeoAPI ISO 19115 Metadata synchronization</a></td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td 
class="unav">jgarnett</td><td><a href="rev/25001/AbstractEnvelope.xhtml">change 
to org.opengis.geometry</a></td></tr>
+<tr><td 
class="rev">24510</td><td>2007-02-19</td><td>desruisseaux</td><td>Moved 
'isIdentity(double tolerance)' method from AbstractMathTransform to 
LinearTransform interface.</td></tr>
+<tr><td class="rev">24485</td><td>2007-02-16</td><td 
class="unav">simboss</td><td><a href="rev/24485/AbstractEnvelope.xhtml">-first 
bunch of changes for the alignment of trunk with 2.3.x</a></td></tr>
+<tr><td 
class="rev">24140</td><td>2007-02-01</td><td>desruisseaux</td><td>Grouped 
coverage-related hints together. Edition in javadoc and code 
formatting.</td></tr>
+<tr><td class="rev">24116</td><td>2007-01-31</td><td 
class="unav">simboss</td><td><a href="rev/24116/AbstractEnvelope.xhtml">-added 
more general method for comparing envelopes with tolerance</a></td></tr>
+<tr><td 
class="rev">22997</td><td>2006-11-26</td><td>desruisseaux</td><td>Replaced the 
use of some deprecated methods (MonolineFormatter.initGeotools --> 
Logging.forceMonolineConsoleOutput; Utilities.unexpectedException --> 
Logging.unexpectedException; GeneralEnvelope.getCoordinateReferenceSystem --> 
Envelope.getCoordinateReferenceSystem).</td></tr>
+<tr><td 
class="rev">22711</td><td>2006-11-12</td><td>desruisseaux</td><td>Moved the 
GeneralGridGeometry.getEnvelope(...) static method as a GeneralEnvelope 
constructor.</td></tr>
+<tr><td 
class="rev">22710</td><td>2006-11-12</td><td>desruisseaux</td><td>Review of 
coverage branch merge: In 'CategoryList', check for the 'no data' category name 
only if the geophysics value is some NaN value. Moved XAffineTransform to a 
public place and added methods for testing axis swapping, as a proposed 
replacement for 'GeneralGridGeometry.swapXY(CoordinateSystem)' (replacement not 
yet done; waiting for the okay from the mailing list). In GeneralGridGeometry, 
added methods for returning a math transform relative to some pixel corner 
instead of pixel center, as a proposed replacement for the 'getTransform(...)' 
public static methods (I would like to remove those static methods in order to 
keep the API a little bit more orthogonal).</td></tr>
+<tr><td 
class="rev">22646</td><td>2006-11-08</td><td>desruisseaux</td><td>Completed 
(but not yet tested) a first implementation of 
MathTransformBuilder.getTransformation().</td></tr>
+<tr><td 
class="rev">22443</td><td>2006-10-27</td><td>desruisseaux</td><td>Splitted 
referencing, extracting metadata in their own module (GEOT-983). As a side 
effect, replaced some calls of CRSUtilities.foo(...) by CRS.foo(...).</td></tr>
+<tr><td 
class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: 
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common 
directory.</td></tr>
+<tr><td 
class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
 of directory tree structure (GEOT-982) phase 1: moved 'src' to 
'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td 
class="unav">jgarnett</td><td><a href="rev/20874/AbstractEnvelope.xhtml">ip 
review</a></td></tr>
+<tr><td 
class="rev">20652</td><td>2006-07-21</td><td>desruisseaux</td><td>Renamed some 
resources. Changed exception type.</td></tr>
+<tr><td 
class="rev">20139</td><td>2006-06-22</td><td>desruisseaux</td><td>Merging the 
coverage branch to trunk: the main change (the only one?) in the referencing 
module seem to be the GeneralEnvelope.equals(...) method.</td></tr>
+<tr><td class="rev">18374</td><td>2006-03-01</td><td>desruisseaux</td><td>One 
more CRS test. Addition of GeneralEnvelope.equals(Envelope, double epsilon) 
method.</td></tr>
+<tr><td 
class="rev">17934</td><td>2006-02-09</td><td>desruisseaux</td><td>Additional 
testing in GO-1 initial implementation (GEOT-415).</td></tr>
+<tr><td 
class="rev">17916</td><td>2006-02-08</td><td>desruisseaux</td><td>Moved the 
basic graphic primitive framework to the 'canvas' package in order to get 
access to protected methods. Initial test suite. Bug fixes (GEOT-415).</td></tr>
+<tr><td 
class="rev">17890</td><td>2006-02-06</td><td>desruisseaux</td><td>First draft 
of a partial port of J2D-renderer to a GO-1 implementation.</td></tr>
+<tr><td 
class="rev">17720</td><td>2006-01-24</td><td>desruisseaux</td><td>Method 
signature change in GeneraleEnvelope before 2.2-RC1 release. This is a 
compatible change if the user recompile its code.</td></tr>
+<tr><td 
class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source 
tag.</td></tr>
+<tr><td 
class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN 
attributes, including the addition of URL attribute.</td></tr>
+<tr><td 
class="rev">17588</td><td>2006-01-13</td><td>desruisseaux</td><td>Added plugin 
dependencies management in Maven 2 build (GEOT-691). Added a first draft of 
javadoc plugin with custom taglets.</td></tr>
+<tr><td 
class="rev">17460</td><td>2006-01-05</td><td>desruisseaux</td><td>Added support 
classes for GO-1 implementation. Partial Maven 2 fixes for the new 
module/renderer module.</td></tr>
+<tr><td class="rev">16526</td><td>2005-10-27</td><td>desruisseaux</td><td>More 
responsabilities moved from GridCoverage2D to GridGeometry2D (GEOT-701). This 
refactoring had a significant impact on Resample2D; the rest of the code should 
stay neutral.</td></tr>
+<tr><td 
class="rev">16172</td><td>2005-10-10</td><td>desruisseaux</td><td>Moved a JTS 
dependency from the CRS class to the JTS class (GEOT-716)</td></tr>
+<tr><td 
class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added 
convenience methods or constructors</td></tr>
+<tr><td 
class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 
'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td 
class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of 
referencing module from main</td></tr>
+<tr><td 
class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare 
branch for splitting main</td></tr>
+<tr><td 
class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized 
I18N resources</td></tr>
+<tr><td 
class="rev">14549</td><td>2005-06-16</td><td>desruisseaux</td><td>Renamed 
PropertyParser as MetadataBuilder; renamed as well their related 
classes.</td></tr>
+<tr><td 
class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since 
javadoc tag</td></tr>
+<tr><td 
class="rev">13046</td><td>2005-04-10</td><td>desruisseaux</td><td>First "should 
be working" (translation: "not yet tested") version of CoverageStack.</td></tr>
+<tr><td class="rev">13045</td><td>2005-04-10</td><td>desruisseaux</td><td>More 
CoverageStack work</td></tr>
+<tr><td 
class="rev">12985</td><td>2005-04-06</td><td>desruisseaux</td><td>First draft 
of CoverageStack</td></tr>
+<tr><td 
class="rev">12960</td><td>2005-04-04</td><td>desruisseaux</td><td>Added 
convenience wrapper methods</td></tr>
+<tr><td 
class="rev">11960</td><td>2005-03-10</td><td>desruisseaux</td><td>First draft 
of GridCoverage 'resampler' operation port</td></tr>
+<tr><td 
class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong 
encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td 
class="unav">dzwiers</td><td><a href="rev/10796/AbstractEnvelope.xhtml">imports 
cleaned</a></td></tr>
+<tr><td 
class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS 
implementation</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/GeneralEnvelope.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/GeneralEnvelope.xhtml?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/GeneralEnvelope.xhtml (added)
+++ sis/ip-review/GeneralEnvelope.xhtml Sun Dec 16 07:40:44 2012
@@ -0,0 +1,92 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralEnvelope history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralEnvelope history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how 
the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/GeneralEnvelope.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td 
class="rev">30776</td><td>2008-06-20</td><td>desruisseaux</td><td>GeoTools 
implementation update for GeoAPI change (GEO-136): Envelope.getCenter renamed 
as getMedian and getLength renamed as getSpan. Deprecated GridRange, to be 
replaced by GridEnvelope.</td></tr>
+<tr><td 
class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated from 
JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override 
annotations in the process.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright 
headers: lib/referencing, this time with feeling (and the el in 
Toolkit)</td></tr>
+<tr><td 
class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update 
referencing headers</td></tr>
+<tr><td 
class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my 
mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, 
since a few tests show that the compiler always select the best overloaded 
flavor working on primitive types (except if an argument is a boolean and the 
other a different primitive type). Updated a few references. Fixed a few 
javadoc warnings by explicit declaration of parameter and return 
values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle 
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move 
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29826</td><td>2008-04-07</td><td>desruisseaux</td><td>More 
support for PixelOrientation in GridGeometry construction and queries. A side 
effect of this work is the refactoring of GridGeometry2D translation method 
into a separated PixelTranslation class.</td></tr>
+<tr><td 
class="rev">29570</td><td>2008-03-07</td><td>desruisseaux</td><td>Renamed 
GeneralEnvelope.validate as GeneralEnvelope.normalize in anticipation of 
GEOT-1724. More TreeNode tests and bug fixes for MosaicImageReader.</td></tr>
+<tr><td 
class="rev">29416</td><td>2008-02-21</td><td>desruisseaux</td><td>Added a 
GeneralEnvelope.validate() method for restricting an envelope to its CRS or CS 
domain of validity, wraping around longitude if needed. Relaxed the 
transformations between GeographicBoundingBox and Envelope, accepting 
GeographicCRS that are not necessarly WGS84.</td></tr>
+<tr><td 
class="rev">29092</td><td>2008-02-05</td><td>desruisseaux</td><td>Documentation 
updates. Java 5 type safety mostly in EPSG factories. LogarithmicTransform1D 
optimization by using the new (and presumably more accurate) Java 5 
Math.log10(double) method.</td></tr>
+<tr><td 
class="rev">28937</td><td>2008-01-25</td><td>desruisseaux</td><td>Reverted the 
whole trunk to revision 28921.</td></tr>
+<tr><td class="rev">28926</td><td>2008-01-24</td><td>acuster</td><td>Revert 
geotools trunk to reversion 29822, hopefully.</td></tr>
+<tr><td class="rev">28923</td><td>2008-01-24</td><td>acuster</td><td>Merge 
from gtbranches</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the 
(at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide 
buttons which are not yet used</td></tr>
+<tr><td 
class="rev">28500</td><td>2007-12-24</td><td>desruisseaux</td><td>Added a new 
GridGeometry implementation (ImageGeometry) has a lightweight placeholder for 
'gridRange' as a Rectangle and 'gridToCRS' as an AffineTransform. Used by 
TileBuilder.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More 
MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name 
in a separated utilities class named 'Classes'. Also added a couple of 
@Override annotations.</td></tr>
+<tr><td class="rev">28069</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 
5 generics in org.geotools.image.io, and partially in 
org.geotools.parameters.</td></tr>
+<tr><td 
class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted 
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">26151</td><td>2007-07-04</td><td>desruisseaux</td><td>More 
accurate support for localization (through ImageReader.getLocale() API). Bug 
fixes.</td></tr>
+<tr><td 
class="rev">26137</td><td>2007-07-03</td><td>desruisseaux</td><td>Image I/O 
GeographicMetadata should now supports read and write operations for most 
attributes. More tests needed.</td></tr>
+<tr><td 
class="rev">25779</td><td>2007-06-08</td><td>desruisseaux</td><td>Added 
CRS.transform(CoordinateOperation, ...) methods, which are able to handle the 
special cases where the source envelope contains a singularity like a pole or 
the 180� longitude. As a side effect, changed Envelope.toString() to a more 
straightforward formatting, easier for debugging.</td></tr>
+<tr><td class="rev">25001</td><td>2007-04-03</td><td 
class="unav">chorner</td><td><a 
href="rev/25001/AbstractEnvelope.xhtml">switched back to geoapi 2.1-SNAPSHOT; 
reverted GeographicBoundingBox</a></td></tr>
+<tr><td class="rev">24973</td><td>2007-03-30</td><td 
class="unav">chorner</td><td><a href="rev/25001/AbstractEnvelope.xhtml">GEO-93: 
GeoTools/GeoAPI ISO 19115 Metadata synchronization</a></td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td 
class="unav">jgarnett</td><td><a href="rev/25001/AbstractEnvelope.xhtml">change 
to org.opengis.geometry</a></td></tr>
+<tr><td 
class="rev">24510</td><td>2007-02-19</td><td>desruisseaux</td><td>Moved 
'isIdentity(double tolerance)' method from AbstractMathTransform to 
LinearTransform interface.</td></tr>
+<tr><td class="rev">24485</td><td>2007-02-16</td><td 
class="unav">simboss</td><td><a href="rev/24485/AbstractEnvelope.xhtml">-first 
bunch of changes for the alignment of trunk with 2.3.x</a></td></tr>
+<tr><td 
class="rev">24140</td><td>2007-02-01</td><td>desruisseaux</td><td>Grouped 
coverage-related hints together. Edition in javadoc and code 
formatting.</td></tr>
+<tr><td class="rev">24116</td><td>2007-01-31</td><td 
class="unav">simboss</td><td><a href="rev/24116/AbstractEnvelope.xhtml">-added 
more general method for comparing envelopes with tolerance</a></td></tr>
+<tr><td 
class="rev">22997</td><td>2006-11-26</td><td>desruisseaux</td><td>Replaced the 
use of some deprecated methods (MonolineFormatter.initGeotools --> 
Logging.forceMonolineConsoleOutput; Utilities.unexpectedException --> 
Logging.unexpectedException; GeneralEnvelope.getCoordinateReferenceSystem --> 
Envelope.getCoordinateReferenceSystem).</td></tr>
+<tr><td 
class="rev">22711</td><td>2006-11-12</td><td>desruisseaux</td><td>Moved the 
GeneralGridGeometry.getEnvelope(...) static method as a GeneralEnvelope 
constructor.</td></tr>
+<tr><td 
class="rev">22710</td><td>2006-11-12</td><td>desruisseaux</td><td>Review of 
coverage branch merge: In 'CategoryList', check for the 'no data' category name 
only if the geophysics value is some NaN value. Moved XAffineTransform to a 
public place and added methods for testing axis swapping, as a proposed 
replacement for 'GeneralGridGeometry.swapXY(CoordinateSystem)' (replacement not 
yet done; waiting for the okay from the mailing list). In GeneralGridGeometry, 
added methods for returning a math transform relative to some pixel corner 
instead of pixel center, as a proposed replacement for the 'getTransform(...)' 
public static methods (I would like to remove those static methods in order to 
keep the API a little bit more orthogonal).</td></tr>
+<tr><td 
class="rev">22646</td><td>2006-11-08</td><td>desruisseaux</td><td>Completed 
(but not yet tested) a first implementation of 
MathTransformBuilder.getTransformation().</td></tr>
+<tr><td 
class="rev">22443</td><td>2006-10-27</td><td>desruisseaux</td><td>Splitted 
referencing, extracting metadata in their own module (GEOT-983). As a side 
effect, replaced some calls of CRSUtilities.foo(...) by CRS.foo(...).</td></tr>
+<tr><td 
class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: 
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common 
directory.</td></tr>
+<tr><td 
class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
 of directory tree structure (GEOT-982) phase 1: moved 'src' to 
'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td 
class="unav">jgarnett</td><td><a href="rev/20874/AbstractEnvelope.xhtml">ip 
review</a></td></tr>
+<tr><td 
class="rev">20652</td><td>2006-07-21</td><td>desruisseaux</td><td>Renamed some 
resources. Changed exception type.</td></tr>
+<tr><td 
class="rev">20139</td><td>2006-06-22</td><td>desruisseaux</td><td>Merging the 
coverage branch to trunk: the main change (the only one?) in the referencing 
module seem to be the GeneralEnvelope.equals(...) method.</td></tr>
+<tr><td class="rev">18374</td><td>2006-03-01</td><td>desruisseaux</td><td>One 
more CRS test. Addition of GeneralEnvelope.equals(Envelope, double epsilon) 
method.</td></tr>
+<tr><td 
class="rev">17934</td><td>2006-02-09</td><td>desruisseaux</td><td>Additional 
testing in GO-1 initial implementation (GEOT-415).</td></tr>
+<tr><td 
class="rev">17916</td><td>2006-02-08</td><td>desruisseaux</td><td>Moved the 
basic graphic primitive framework to the 'canvas' package in order to get 
access to protected methods. Initial test suite. Bug fixes (GEOT-415).</td></tr>
+<tr><td 
class="rev">17890</td><td>2006-02-06</td><td>desruisseaux</td><td>First draft 
of a partial port of J2D-renderer to a GO-1 implementation.</td></tr>
+<tr><td 
class="rev">17720</td><td>2006-01-24</td><td>desruisseaux</td><td>Method 
signature change in GeneraleEnvelope before 2.2-RC1 release. This is a 
compatible change if the user recompile its code.</td></tr>
+<tr><td 
class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source 
tag.</td></tr>
+<tr><td 
class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN 
attributes, including the addition of URL attribute.</td></tr>
+<tr><td 
class="rev">17588</td><td>2006-01-13</td><td>desruisseaux</td><td>Added plugin 
dependencies management in Maven 2 build (GEOT-691). Added a first draft of 
javadoc plugin with custom taglets.</td></tr>
+<tr><td 
class="rev">17460</td><td>2006-01-05</td><td>desruisseaux</td><td>Added support 
classes for GO-1 implementation. Partial Maven 2 fixes for the new 
module/renderer module.</td></tr>
+<tr><td class="rev">16526</td><td>2005-10-27</td><td>desruisseaux</td><td>More 
responsabilities moved from GridCoverage2D to GridGeometry2D (GEOT-701). This 
refactoring had a significant impact on Resample2D; the rest of the code should 
stay neutral.</td></tr>
+<tr><td 
class="rev">16172</td><td>2005-10-10</td><td>desruisseaux</td><td>Moved a JTS 
dependency from the CRS class to the JTS class (GEOT-716)</td></tr>
+<tr><td 
class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added 
convenience methods or constructors</td></tr>
+<tr><td 
class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 
'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td 
class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of 
referencing module from main</td></tr>
+<tr><td 
class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare 
branch for splitting main</td></tr>
+<tr><td 
class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized 
I18N resources</td></tr>
+<tr><td 
class="rev">14549</td><td>2005-06-16</td><td>desruisseaux</td><td>Renamed 
PropertyParser as MetadataBuilder; renamed as well their related 
classes.</td></tr>
+<tr><td 
class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since 
javadoc tag</td></tr>
+<tr><td 
class="rev">13046</td><td>2005-04-10</td><td>desruisseaux</td><td>First "should 
be working" (translation: "not yet tested") version of CoverageStack.</td></tr>
+<tr><td class="rev">13045</td><td>2005-04-10</td><td>desruisseaux</td><td>More 
CoverageStack work</td></tr>
+<tr><td 
class="rev">12985</td><td>2005-04-06</td><td>desruisseaux</td><td>First draft 
of CoverageStack</td></tr>
+<tr><td 
class="rev">12960</td><td>2005-04-04</td><td>desruisseaux</td><td>Added 
convenience wrapper methods</td></tr>
+<tr><td 
class="rev">11960</td><td>2005-03-10</td><td>desruisseaux</td><td>First draft 
of GridCoverage 'resampler' operation port</td></tr>
+<tr><td 
class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong 
encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td 
class="unav">dzwiers</td><td><a href="rev/10796/AbstractEnvelope.xhtml">imports 
cleaned</a></td></tr>
+<tr><td 
class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS 
implementation</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/GeneralEnvelope.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/GeneralEnvelope.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/AbstractEnvelope.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/10796/AbstractEnvelope.xhtml?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/rev/10796/AbstractEnvelope.xhtml (added)
+++ sis/ip-review/rev/10796/AbstractEnvelope.xhtml Sun Dec 16 07:40:44 2012
@@ -0,0 +1,77 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralEnvelope changes for revisions 
10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralEnvelope changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto 
reformat</cite>" tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import 
ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters 
is broken.
+This commit has been reverted, except for the removal of really unused imports 
which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change 
--ignore-all-space --ignore-eol-style" -r10795:10796 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractEnvelope.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2004, Institut de Recherche pour le 
Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2004, Institut de Recherche pour le 
D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General 
Public</pre></td></tr>
+<tr><td><pre>package org.geotools.geometry;
+
+// J2SE dependencies
+import java.util.Arrays;
+<span class="del">import java.io.Serializable;</span>
+<span class="del">import java.awt.geom.Rectangle2D;</span>
+
+<span class="del">// Geotools dependencies</span>
+import org.geotools.resources.Utilities;
+import org.geotools.resources.cts.Resources;
+<span class="del">import org.geotools.resources.cts.ResourceKeys;</span>
+import org.geotools.resources.geometry.XRectangle2D;
+<span class="del"></span>
+<span class="del">// OpenGIS dependencies</span>
+import org.opengis.spatialschema.geometry.Envelope;
+<span class="del">import 
org.opengis.spatialschema.geometry.DirectPosition;</span>
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+<span class="del">import 
org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+
+
+/**</pre></td>
+<td><pre>package org.geotools.geometry;
+
+// J2SE dependencies
+<span class="add">import java.awt.geom.Rectangle2D;</span>
+<span class="add">import java.io.Serializable;</span>
+import java.util.Arrays;
+
+import org.geotools.resources.Utilities;
+<span class="add">import org.geotools.resources.cts.ResourceKeys;</span>
+import org.geotools.resources.cts.Resources;
+import org.geotools.resources.geometry.XRectangle2D;
+<span class="add">import 
org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+<span class="add">import 
org.opengis.spatialschema.geometry.DirectPosition;</span>
+import org.opengis.spatialschema.geometry.Envelope;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+
+/**</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/AbstractEnvelope.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/20874/AbstractEnvelope.xhtml?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/rev/20874/AbstractEnvelope.xhtml (added)
+++ sis/ip-review/rev/20874/AbstractEnvelope.xhtml Sun Dec 16 07:40:44 2012
@@ -0,0 +1,60 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralEnvelope changes for revisions 
20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralEnvelope changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your 
option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer 
other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions 
are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change 
--ignore-all-space --ignore-eol-style" -r20873:20874 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractEnvelope.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee 
(PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; 
either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any 
later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser 
General Public</span>
+<span class="del"> *    License along with this library; if not, write to the 
Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, 
MA  02111-1307  USA</span>
+ */
+package org.geotools.geometry;</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2004-2006, GeoTools Project Managment Committee 
(PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software 
Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.geometry;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24116/AbstractEnvelope.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/24116/AbstractEnvelope.xhtml?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/rev/24116/AbstractEnvelope.xhtml (added)
+++ sis/ip-review/rev/24116/AbstractEnvelope.xhtml Sun Dec 16 07:40:44 2012
@@ -0,0 +1,111 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralEnvelope changes for revisions 
24115:24116</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralEnvelope changes for revisions 24115:24116</h1>
+<p>The idea of giving the choice between relative or absolute comparisons has 
been keep.
+This is a concept found in various libraries, not an original contribution.
+On the actual code (excluding documentation):</p>
+<ul>
+  <li>The removal of the call to <code>ensureNonNull(…)</code> has been 
reverted.</li>
+  <li>The change in the <code>assert</code> statement (invoking 
<code>get…(envelope)</code> instead than <code>envelope.get…()</code>) has 
been reverted.</li>
+  <li>The only significant addition, which can be summarized by "<code>if 
(!relativeToLength) epsilon = eps</code>" , is trivial and has been written 
differently in Geotk/SIS anyway.</li>
+</ul>
+<p>The Javadoc, which seems a massive contribution, is actually a 
copy-and-paste of the Javadoc of the <code>equals(Envelope,  double)</code>
+method just above the contribution. The only new documentation are "<cite>If 
<code>relativeToLength</code> is set to true</cite>" and
+"<cite>If <code>relativeToLength</code> is set to false,</cite> [the actual 
tolerance value for a given dimension i]<cite> is <code>eps</code>.</cite>"
+where the […] part is an other copy-and-paste.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change 
--ignore-all-space --ignore-eol-style" -r24115:24116 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractEnvelope.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24115</th><th>Revision 24116</th></tr>
+<tr><td><pre>* @source $URL$
+* @version $Id$
+* @author Martin Desruisseaux
+*
+* @see Envelope2D
+* @see org.geotools.geometry.jts.ReferencedEnvelope</pre></td>
+<td><pre>* @source $URL$
+* @version $Id$
+* @author Martin Desruisseaux
+<span class="add">* @author Simone Giannecchini</span>
+*
+* @see Envelope2D
+* @see org.geotools.geometry.jts.ReferencedEnvelope</pre></td></tr>
+<tr><td><pre> * @since 2.3
+ */
+public boolean equals(final Envelope envelope, final double eps) {
+<span class="del">    ensureNonNull("envelope", envelope);</span>
+    final int dimension = getDimension();
+    if (envelope.getDimension() != dimension) {
+        return false;
+    }
+<span class="del">    assert equalsIgnoreMetadata(crs, 
envelope.getCoordinateReferenceSystem()) : envelope;</span>
+    for (int i=0; i&lt;dimension; i++) {
+<span class="del">        double epsilon = Math.max(getLength(i), 
envelope.getLength(i));</span>
+        epsilon = (epsilon&gt;0 &amp;&amp; 
epsilon&lt;Double.POSITIVE_INFINITY) ? epsilon*eps : eps;
+        // Comparaison below uses '!' in order to catch NaN values.
+        if (!(Math.abs(getMinimum(i) - envelope.getMinimum(i)) &lt;= epsilon 
&amp;&amp;
+              Math.abs(getMaximum(i) - envelope.getMaximum(i)) &lt;= 
epsilon))</pre></td>
+<td><pre> * @since 2.3
+ */
+public boolean equals(final Envelope envelope, final double eps) {
+<span class="add">    return equals(envelope, eps,true);</span>
+<span class="add">}</span>
+<span class="add">/**</span>
+<span class="add"> * Compares to the specified envelope for equality up to the 
specified tolerance value.</span>
+<span class="add"> * The tolerance value {@code eps} can be either relative to 
the {@linkplain #getLength</span>
+<span class="add"> * envelope length}along each dimension or can be an absolut 
value (as for example some</span>
+<span class="add"> * ground resolution of a {@link GridCoverage}.</span>
+<span class="add"> *</span>
+<span class="add"> * If &lt;code&gt;relativeToLength&lt;/code&gt; is set to 
true, the actual tolerance value for a given dimension</span>
+<span class="add"> * &lt;var&gt;i&lt;/var&gt; is {@code eps}&amp;times;{@code 
length} where {@code length} is the maximum of</span>
+<span class="add"> * {@linkplain #getLength this envelope length} and the 
specified envelope length along</span>
+<span class="add"> * dimension &lt;var&gt;i&lt;/var&gt;.</span>
+<span class="add"> *</span>
+<span class="add"> * If &lt;code&gt;relativeToLength&lt;/code&gt; is set to 
false, the actual tolerance value for a given dimension</span>
+<span class="add"> * &lt;var&gt;i&lt;/var&gt; is {@code eps}.</span>
+<span class="add"> *</span>
+<span class="add"> * &lt;p&gt;</span>
+<span class="add"> * Relative tolerance value (as opposed to absolute 
tolerance value) help to workaround the</span>
+<span class="add"> * fact that tolerance value are CRS dependent. For example 
the tolerance value need to be</span>
+<span class="add"> * smaller for geographic CRS than for UTM projections, 
because the former typically has a</span>
+<span class="add"> * range of -180 to 180° while the later can have a range 
of thousands of meters.</span>
+<span class="add"> * &lt;p&gt;</span>
+<span class="add"> * This method assumes that the specified envelope uses the 
same CRS than this envelope.</span>
+<span class="add"> * For performance reason, it will no be verified unless 
J2SE assertions are enabled.</span>
+<span class="add"> *</span>
+<span class="add"> * @see #contains(Envelope, boolean)</span>
+<span class="add"> * @see #intersects(Envelope, boolean)</span>
+<span class="add"> *</span>
+<span class="add"> * @since 2.4</span>
+<span class="add"> */</span>
+<span class="add">public boolean equals(final Envelope envelope, final double 
eps,final boolean relativeToLength) {</span>
+    final int dimension = getDimension();
+    if (envelope.getDimension() != dimension) {
+        return false;
+    }
+<span class="add">    assert equalsIgnoreMetadata(crs, 
getCoordinateReferenceSystem(envelope)) : envelope;</span>
+<span class="add">    double epsilon;</span>
+    for (int i=0; i&lt;dimension; i++) {
+<span class="add">        if(relativeToLength){</span>
+<span class="add">            epsilon = Math.max(getLength(i), 
envelope.getLength(i));</span>
+        epsilon = (epsilon&gt;0 &amp;&amp; 
epsilon&lt;Double.POSITIVE_INFINITY) ? epsilon*eps : eps;
+<span class="add">        }</span>
+<span class="add">        else</span>
+<span class="add">           epsilon=eps;</span>
+        // Comparaison below uses '!' in order to catch NaN values.
+        if (!(Math.abs(getMinimum(i) - envelope.getMinimum(i)) &lt;= epsilon 
&amp;&amp;
+              Math.abs(getMaximum(i) - envelope.getMaximum(i)) &lt;= 
epsilon))</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24116/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24116/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24116/HEADER.html
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/24116/HEADER.html?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/rev/24116/HEADER.html (added)
+++ sis/ip-review/rev/24116/HEADER.html Sun Dec 16 07:40:44 2012
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 24116</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 24116</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>simboss</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-01-31</td></tr>
+  <tr><td><b>Message:</b></td><td>-added more general method for comparing 
envelopes with tolerance</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24116/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24116/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24485/AbstractEnvelope.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/24485/AbstractEnvelope.xhtml?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/rev/24485/AbstractEnvelope.xhtml (added)
+++ sis/ip-review/rev/24485/AbstractEnvelope.xhtml Sun Dec 16 07:40:44 2012
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralEnvelope changes for revisions 
24484:24485</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralEnvelope changes for revisions 24484:24485</h1>
+<p>Trivial formatting change which has been reverted anyway.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change 
--ignore-all-space --ignore-eol-style" -r24484:24485 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractEnvelope.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24484</th><th>Revision 24485</th></tr>
+<tr><td><pre>if (relativeToLength) {
+    epsilon = Math.max(getLength(i), envelope.getLength(i));
+    epsilon = (epsilon&gt;0 &amp;&amp; epsilon&lt;Double.POSITIVE_INFINITY) ? 
epsilon*eps : eps;
+<span class="del">} else {</span>
+    epsilon = eps;
+<span class="del">}</span>
+// Comparaison below uses '!' in order to catch NaN values.
+if (!(Math.abs(getMinimum(i) - envelope.getMinimum(i)) &lt;= epsilon &amp;&amp;
+      Math.abs(getMaximum(i) - envelope.getMaximum(i)) &lt;= 
epsilon))</pre></td>
+<td><pre>if (relativeToLength) {
+    epsilon = Math.max(getLength(i), envelope.getLength(i));
+    epsilon = (epsilon&gt;0 &amp;&amp; epsilon&lt;Double.POSITIVE_INFINITY) ? 
epsilon*eps : eps;
+<span class="add">}</span>
+<span class="add">else</span>
+    epsilon = eps;
+// Comparaison below uses '!' in order to catch NaN values.
+if (!(Math.abs(getMinimum(i) - envelope.getMinimum(i)) &lt;= epsilon &amp;&amp;
+      Math.abs(getMaximum(i) - envelope.getMaximum(i)) &lt;= 
epsilon))</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24485/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24485/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24485/HEADER.html
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/24485/HEADER.html?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/rev/24485/HEADER.html (added)
+++ sis/ip-review/rev/24485/HEADER.html Sun Dec 16 07:40:44 2012
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 24485</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 24485</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>simboss</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-02-16</td></tr>
+  <tr><td><b>Message:</b></td><td>-first bunch of changes for the alignment of 
trunk with 2.3.x</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24485/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24485/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25001/AbstractEnvelope.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/25001/AbstractEnvelope.xhtml?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/rev/25001/AbstractEnvelope.xhtml (added)
+++ sis/ip-review/rev/25001/AbstractEnvelope.xhtml Sun Dec 16 07:40:44 2012
@@ -0,0 +1,43 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralEnvelope changes for revisions 
24924:25001</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralEnvelope changes for revisions 24924:25001</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change 
--ignore-all-space --ignore-eol-style" -r24924:25001 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractEnvelope.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 25001</th></tr>
+<tr><td><pre>import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.TransformException;
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+<span class="del">import 
org.opengis.spatialschema.geometry.DirectPosition;</span>
+<span class="del">import org.opengis.spatialschema.geometry.Envelope;</span>
+<span class="del">import 
org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+<span class="del">import 
org.opengis.spatialschema.geometry.MismatchedReferenceSystemException;</span>
+
+// Geotools dependencies
+import org.geotools.referencing.CRS;</pre></td>
+<td><pre>import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.TransformException;
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+<span class="add">import org.opengis.geometry.DirectPosition;</span>
+<span class="add">import org.opengis.geometry.Envelope;</span>
+<span class="add">import 
org.opengis.geometry.MismatchedDimensionException;</span>
+<span class="add">import 
org.opengis.geometry.MismatchedReferenceSystemException;</span>
+
+// Geotools dependencies
+import org.geotools.referencing.CRS;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25001/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25001/AbstractEnvelope.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25001/HEADER.html
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/25001/HEADER.html?rev=1422478&view=auto
==============================================================================
--- sis/ip-review/rev/25001/HEADER.html (added)
+++ sis/ip-review/rev/25001/HEADER.html Sun Dec 16 07:40:44 2012
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 25001</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 25001</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>chorner</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-04-03</td></tr>
+  <tr><td><b>Message:</b></td><td>switched back to geoapi 2.1-SNAPSHOT; 
reverted GeographicBoundingBox</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25001/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25001/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html


Reply via email to