Author: desruisseaux
Date: Fri Jun  6 15:12:39 2014
New Revision: 1600908

URL: http://svn.apache.org/r1600908
Log:
Add IP review.

Added:
    sis/ip-review/MathTransformSeparator.xhtml   (with props)
    sis/ip-review/rev/20874/MathTransformSeparator.xhtml   (with props)
    sis/ip-review/rev/25050/MathTransformSeparator.xhtml   (with props)
    sis/ip-review/rev/28718/
    sis/ip-review/rev/28718/HEADER.html   (with props)
    sis/ip-review/rev/28718/MathTransformSeparator.xhtml   (with props)

Added: sis/ip-review/MathTransformSeparator.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/MathTransformSeparator.xhtml?rev=1600908&view=auto
==============================================================================
--- sis/ip-review/MathTransformSeparator.xhtml (added)
+++ sis/ip-review/MathTransformSeparator.xhtml Fri Jun  6 15:12:39 2014
@@ -0,0 +1,61 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>MathTransformSeparator history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>MathTransformSeparator history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how 
the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/DimensionFilter.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright 
headers: lib/referencing, this time with feeling (and the el in 
Toolkit)</td></tr>
+<tr><td class="rev">30639</td><td>2008-06-12</td><td>acuster</td><td>Copyright 
headers: cleanup library/referencing</td></tr>
+<tr><td 
class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update 
referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle 
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move 
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td 
class="rev">29829</td><td>2008-04-07</td><td>desruisseaux</td><td>Inside 
synchronized blocks, avoid to call methods that user could override.</td></tr>
+<tr><td 
class="rev">29806</td><td>2008-04-04</td><td>desruisseaux</td><td>Added the 
capability to use a custom DimensionFilter on GridGeometry2D 
construction.</td></tr>
+<tr><td 
class="rev">29782</td><td>2008-04-03</td><td>desruisseaux</td><td>Formatting.</td></tr>
+<tr><td 
class="rev">29092</td><td>2008-02-05</td><td>desruisseaux</td><td>Documentation 
updates. Java 5 type safety mostly in EPSG factories. LogarithmicTransform1D 
optimization by using the new (and presumably more accurate) Java 5 
Math.log10(double) method.</td></tr>
+<tr><td 
class="rev">28974</td><td>2008-01-27</td><td>desruisseaux</td><td>GEOT-1659 
fix: CRS.decode(...) search for URN factory even if system hints contains 
"force longitude first" hint.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the 
(at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28718</td><td>2008-01-11</td><td 
class="unav">simboss</td><td><a 
href="rev/28718/MathTransformSeparator.xhtml">-adding constructor with 
hints</a></td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide 
buttons which are not yet used</td></tr>
+<tr><td 
class="rev">28527</td><td>2007-12-28</td><td>desruisseaux</td><td>GridCoverage2D.evaluate(DirectPosition)
 now reprojects on the fly if the DirectPosition CRS is different than the 
GridCoverage CRS.</td></tr>
+<tr><td 
class="rev">28520</td><td>2007-12-27</td><td>desruisseaux</td><td>Added 
@Override annotation for safety.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid 
unecessary synchronisation; rely on auto-boxing in order to give a chance to 
the JVM to reuse its cached values.</td></tr>
+<tr><td 
class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted 
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25050</td><td>2007-04-06</td><td 
class="unav">jgarnett</td><td><a 
href="rev/25050/MathTransformSeparator.xhtml">example of custom file based 
TestSutie, copy JTS parsing code over to unsupported/geometry</a></td></tr>
+<tr><td 
class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: 
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common 
directory.</td></tr>
+<tr><td 
class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
 of directory tree structure (GEOT-982) phase 1: moved 'src' to 
'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td 
class="unav">jgarnett</td><td><a 
href="rev/20874/MathTransformSeparator.xhtml">ip review</a></td></tr>
+<tr><td 
class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source 
tag.</td></tr>
+<tr><td 
class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN 
attributes, including the addition of URL attribute.</td></tr>
+<tr><td 
class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 
'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td 
class="rev">15325</td><td>2005-08-13</td><td>desruisseaux</td><td>Created a 
matrix package on top of vecmath / Fixed 'getPositionalAccuracy' 
issues</td></tr>
+<tr><td 
class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of 
referencing module from main</td></tr>
+<tr><td 
class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare 
branch for splitting main</td></tr>
+<tr><td 
class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized 
I18N resources</td></tr>
+<tr><td 
class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since 
javadoc tag</td></tr>
+<tr><td 
class="rev">13922</td><td>2005-05-29</td><td>desruisseaux</td><td>Renaming of 
remainding GeoAPI implementations. Renaming is now finished.</td></tr>
+<tr><td 
class="rev">12965</td><td>2005-04-05</td><td>desruisseaux</td><td>Merged 
'factory-hints' branch r12393:12964 into the trunk. Added 
'getImplementationHints()' method after the merge into Factory implementations, 
in order to get Geotools to compile with Maven.</td></tr>
+<tr><td 
class="rev">11960</td><td>2005-03-10</td><td>desruisseaux</td><td>First draft 
of GridCoverage 'resampler' operation port</td></tr>
+<tr><td 
class="rev">11654</td><td>2005-02-25</td><td>desruisseaux</td><td>GridGeometry 
work, which includes a first working version of DimensionFilter</td></tr>
+<tr><td 
class="rev">11623</td><td>2005-02-24</td><td>desruisseaux</td><td>Completed the 
port of 'separateInput'. 'separateOutput' remain to be done. Both are needed 
for GridGeometry in the grid coverage package.</td></tr>
+<tr><td 
class="rev">11572</td><td>2005-02-23</td><td>desruisseaux</td><td>Initial port 
of sub-transform, required for some grid coverages</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/MathTransformSeparator.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/MathTransformSeparator.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/MathTransformSeparator.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/20874/MathTransformSeparator.xhtml?rev=1600908&view=auto
==============================================================================
--- sis/ip-review/rev/20874/MathTransformSeparator.xhtml (added)
+++ sis/ip-review/rev/20874/MathTransformSeparator.xhtml Fri Jun  6 15:12:39 
2014
@@ -0,0 +1,51 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>MathTransformSeparator changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>MathTransformSeparator changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your 
option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer 
other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions 
are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change 
--ignore-all-space --ignore-eol-style" -r20873:20874 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/DimensionFilter.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Managment Committee 
(PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *</span>
+<span class="add"> *   (C) 2003-2006, Geotools Project Managment Committee 
(PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it 
and/or</pre></td></tr>
+<tr><td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty 
of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser 
General Public</span>
+<span class="del"> *    License along with this library; if not, write to the 
Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, 
MA  02111-1307  USA</span>
+ */
+package org.geotools.referencing.operation.transform;</pre></td>
+<td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.referencing.operation.transform;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/MathTransformSeparator.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/MathTransformSeparator.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/MathTransformSeparator.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/25050/MathTransformSeparator.xhtml?rev=1600908&view=auto
==============================================================================
--- sis/ip-review/rev/25050/MathTransformSeparator.xhtml (added)
+++ sis/ip-review/rev/25050/MathTransformSeparator.xhtml Fri Jun  6 15:12:39 
2014
@@ -0,0 +1,58 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>MathTransformSeparator changes for revisions 25049:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>MathTransformSeparator changes for revisions 25049:25050</h1>
+<p>This change is not relevant to Apache SIS since we will not port 
<code>ReferencingFactoryFinder</code>.
+The plan is to depend on some dependency injection framework instead.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change 
--ignore-all-space --ignore-eol-style" -r25049:25050 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/DimensionFilter.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25049</th><th>Revision 25050</th></tr>
+<tr><td><pre>import org.opengis.referencing.operation.MathTransformFactory;
+
+// Geotools dependencies
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+import org.geotools.referencing.operation.LinearTransform;
+import org.geotools.referencing.operation.matrix.XMatrix;
+import org.geotools.referencing.operation.matrix.MatrixFactory;</pre></td>
+<td><pre>import org.opengis.referencing.operation.MathTransformFactory;
+
+// Geotools dependencies
+<span class="add">import 
org.geotools.referencing.ReferencingFactoryFinder;</span>
+import org.geotools.referencing.operation.LinearTransform;
+import org.geotools.referencing.operation.matrix.XMatrix;
+import org.geotools.referencing.operation.matrix.MatrixFactory;</pre></td></tr>
+<tr><td><pre>private final MathTransformFactory factory;
+
+/**
+<span class="del"> * Constructs a dimension filter with the {@linkplain 
FactoryFinder#getMathTransformFactory</span>
+ * default math transform factory}.
+ */
+public DimensionFilter() {
+<span class="del">    this(FactoryFinder.getMathTransformFactory(null));</span>
+}
+
+/**</pre></td>
+<td><pre>private final MathTransformFactory factory;
+
+/**
+<span class="add"> * Constructs a dimension filter with the {@linkplain 
ReferencingFactoryFinder#getMathTransformFactory</span>
+ * default math transform factory}.
+ */
+public DimensionFilter() {
+<span class="add">    
this(ReferencingFactoryFinder.getMathTransformFactory(null));</span>
+}
+
+/**</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/MathTransformSeparator.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/MathTransformSeparator.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/28718/HEADER.html
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/28718/HEADER.html?rev=1600908&view=auto
==============================================================================
--- sis/ip-review/rev/28718/HEADER.html (added)
+++ sis/ip-review/rev/28718/HEADER.html Fri Jun  6 15:12:39 2014
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 28718</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 28718</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>simboss</td></tr>
+  <tr><td><b>Date:</b></td><td>2008-01-11</td></tr>
+  <tr><td><b>Message:</b></td><td>-adding constructor with hints</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/28718/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/28718/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/28718/MathTransformSeparator.xhtml
URL: 
http://svn.apache.org/viewvc/sis/ip-review/rev/28718/MathTransformSeparator.xhtml?rev=1600908&view=auto
==============================================================================
--- sis/ip-review/rev/28718/MathTransformSeparator.xhtml (added)
+++ sis/ip-review/rev/28718/MathTransformSeparator.xhtml Fri Jun  6 15:12:39 
2014
@@ -0,0 +1,69 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+  <head>
+    <meta charset="UTF-8"/>
+    <title>MathTransformSeparator changes for revisions 28717:28718</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>MathTransformSeparator changes for revisions 28717:28718</h1>
+<p>This change is not relevant to Apache SIS since we will not port 
<code>ReferencingFactoryFinder</code>
+and their <code>Hints</code>. The plan is to depend on some dependency 
injection framework instead.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change 
--ignore-all-space --ignore-eol-style" -r28717:28718 
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/DimensionFilter.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 28717</th><th>Revision 28718</th></tr>
+<tr><td><pre>import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransformFactory;
+
+import org.geotools.referencing.ReferencingFactoryFinder;
+import org.geotools.referencing.operation.LinearTransform;
+import org.geotools.referencing.operation.matrix.XMatrix;</pre></td>
+<td><pre>import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransformFactory;
+
+<span class="add">import org.geotools.factory.Hints;</span>
+import org.geotools.referencing.ReferencingFactoryFinder;
+import org.geotools.referencing.operation.LinearTransform;
+import org.geotools.referencing.operation.matrix.XMatrix;</pre></td></tr>
+<tr><td><pre>* @source $URL$
+* @version $Id$
+* @author Martin Desruisseaux
+*
+* @todo This class is specific to Geotools implementation; it is better to 
avoid it if
+*       you can. It could be generalized a bit if we perform the same 
operations on</pre></td>
+<td><pre>* @source $URL$
+* @version $Id$
+* @author Martin Desruisseaux
+<span class="add">* @author Simone Giannecchini</span>
+*
+* @todo This class is specific to Geotools implementation; it is better to 
avoid it if
+*       you can. It could be generalized a bit if we perform the same 
operations on</pre></td></tr>
+<tr><td><pre>}
+
+/**
+ * Constructs a dimension filter with the specified factory.
+ *
+ * @param factory The factory for the creation of new math 
transforms.</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Constructs a dimension filter with a {@linkplain 
ReferencingFactoryFinder#getMathTransformFactory</span>
+<span class="add"> * math transform factory built using the provided 
hints}.</span>
+<span class="add"> * @param hints to control the creation of the {@link 
MathTransformFactory}.</span>
+<span class="add"> */</span>
+<span class="add">public DimensionFilter(Hints hints) {</span>
+<span class="add">    
this(ReferencingFactoryFinder.getMathTransformFactory(hints));</span>
+<span class="add">}</span>
+<span class="add"></span>
+<span class="add">/**</span>
+ * Constructs a dimension filter with the specified factory.
+ *
+ * @param factory The factory for the creation of new math 
transforms.</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/28718/MathTransformSeparator.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/28718/MathTransformSeparator.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html


Reply via email to