Author: desruisseaux
Date: Tue Jul 19 12:13:03 2016
New Revision: 1753371
URL: http://svn.apache.org/viewvc?rev=1753371&view=rev
Log:
Add IP review for DefaultConcatenatedOperation.
Added:
sis/ip-review/DefaultConcatenatedOperation.xhtml (with props)
sis/ip-review/rev/10796/DefaultConcatenatedOperation.xhtml (with props)
sis/ip-review/rev/20874/DefaultConcatenatedOperation.xhtml (with props)
Added: sis/ip-review/DefaultConcatenatedOperation.xhtml
URL:
http://svn.apache.org/viewvc/sis/ip-review/DefaultConcatenatedOperation.xhtml?rev=1753371&view=auto
==============================================================================
--- sis/ip-review/DefaultConcatenatedOperation.xhtml (added)
+++ sis/ip-review/DefaultConcatenatedOperation.xhtml Tue Jul 19 12:13:03 2016
@@ -0,0 +1,70 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+ <head>
+ <meta charset="UTF-8"/>
+ <title>DefaultConcatenatedOperation history</title>
+ <style type="text/css" media="all">
+ @import url("./reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>DefaultConcatenatedOperation history</h1>
+ <p>Click on the commit message for inspecting the <code>diff</code> and how
the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultConcatenatedOperation.java</code></blockquote>
+<table>
+ <tr>
+ <th>Rev.</th>
+ <th>Date</th>
+ <th>Author</th>
+ <th class="last">Message</th>
+ </tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in
Toolkit)</td></tr>
+<tr><td
class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update
referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29845</td><td>2008-04-08</td><td>desruisseaux</td><td>More
aggressive simplification of MathTransforms during concatenation. It is
probably related to GEOT-1419, but I have not verified. This fix results in
drastic performance improvement for the cases where
DefaultConcatenatedTransform previously failed to see concatenation that could
be simplified to identity transform. Those cases occured more often in 3D or 4D
cases. It may have some benefit in the pure 2D case as well, but probably less
often.</td></tr>
+<tr><td
class="rev">29753</td><td>2008-04-01</td><td>desruisseaux</td><td>Applied
parameterized types as a side-effect of hunting for a
DimensionMismatchException during reprojection.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the
(at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More
MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name
in a separated utilities class named 'Classes'. Also added a couple of
@Override annotations.</td></tr>
+<tr><td
class="rev">28107</td><td>2007-11-28</td><td>desruisseaux</td><td>Updated for
recent changes in GeoAPI interfaces.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid
unecessary synchronisation; rely on auto-boxing in order to give a chance to
the JVM to reuse its cached values.</td></tr>
+<tr><td
class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td
class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common
directory.</td></tr>
+<tr><td
class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to
'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td
class="unav">jgarnett</td><td><a
href="rev/20874/DefaultConcatenatedOperation.xhtml">ip review</a></td></tr>
+<tr><td
class="rev">19557</td><td>2006-05-18</td><td>desruisseaux</td><td>AuthorityBackedFactory
now take inverse transform in account. Improved pseudo-WKT formatting for
CoordinateOperation.</td></tr>
+<tr><td
class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source
tag.</td></tr>
+<tr><td
class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN
attributes, including the addition of URL attribute.</td></tr>
+<tr><td
class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the
'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td
class="rev">15325</td><td>2005-08-13</td><td>desruisseaux</td><td>Created a
matrix package on top of vecmath / Fixed 'getPositionalAccuracy'
issues</td></tr>
+<tr><td
class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of
referencing module from main</td></tr>
+<tr><td
class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare
branch for splitting main</td></tr>
+<tr><td
class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized
I18N resources</td></tr>
+<tr><td class="rev">14608</td><td>2005-06-25</td><td>desruisseaux</td><td>EPSG
authority factory now uses path informations for ConcatenatedOperation object
creations / Added PostgreSQL plugin (mostly as a demo) / Javadoc fixes</td></tr>
+<tr><td
class="rev">14593</td><td>2005-06-23</td><td>desruisseaux</td><td>First JUnit
test for 'createCoordinateOperation' (GEOT-589)</td></tr>
+<tr><td
class="rev">14235</td><td>2005-06-10</td><td>desruisseaux</td><td>Replaced
_PROPERTY suffix by _KEY as of GEOT-577</td></tr>
+<tr><td
class="rev">14205</td><td>2005-06-09</td><td>desruisseaux</td><td>Updated to
GeoAPI 2.0 final release</td></tr>
+<tr><td
class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since
javadoc tag</td></tr>
+<tr><td
class="rev">13922</td><td>2005-05-29</td><td>desruisseaux</td><td>Renaming of
remainding GeoAPI implementations. Renaming is now finished.</td></tr>
+<tr><td
class="rev">13906</td><td>2005-05-28</td><td>desruisseaux</td><td>Renamed some
'Default' prefix as 'Abstract'</td></tr>
+<tr><td
class="rev">13836</td><td>2005-05-26</td><td>desruisseaux</td><td>Added
'Default' suffix to some CRS implementations: partial work</td></tr>
+<tr><td
class="rev">13387</td><td>2005-05-06</td><td>desruisseaux</td><td>Added
Hints.LENIENT_DATUM_SHIFT and the necessary mechanic to honor it</td></tr>
+<tr><td
class="rev">11146</td><td>2005-02-07</td><td>desruisseaux</td><td>CoordinateOperationFactory
refactoring</td></tr>
+<tr><td
class="rev">11144</td><td>2005-02-07</td><td>desruisseaux</td><td>Fixed
GEOT-400 (create appropriate instance of Operation subclasses)</td></tr>
+<tr><td class="rev">11140</td><td>2005-02-06</td><td>desruisseaux</td><td>Work
in progres for GEOT-400 (CoordinateOperationFactory should create appropriate
subclass of CoordinateOperation)</td></tr>
+<tr><td
class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong
encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td
class="unav">dzwiers</td><td><a
href="rev/10796/DefaultConcatenatedOperation.xhtml">imports
cleaned</a></td></tr>
+<tr><td class="rev">9267</td><td>2004-11-23</td><td>desruisseaux</td><td>First
draft of a coordinate transformation factory</td></tr>
+<tr><td
class="rev">8796</td><td>2004-10-22</td><td>desruisseaux</td><td>Cleaning
referencing's operation basic package</td></tr>
+<tr><td class="rev">8518</td><td>2004-10-11</td><td>desruisseaux</td><td>Apply
changes voted in OGC meeting at Southampton: use of Identifier and
GenericName</td></tr>
+<tr><td
class="rev">6888</td><td>2004-07-14</td><td>desruisseaux</td><td>Update for
GeoAPI changes (Info --> IdentifiedObject)</td></tr>
+<tr><td
class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS
implementation</td></tr>
+<tr><td class="rev">6325</td><td>2004-06-04</td><td>desruisseaux</td><td>Added
MathTransform implementations</td></tr>
+<tr><td class="rev">6257</td><td>2004-05-31</td><td>desruisseaux</td><td>First
set of operation classes</td></tr>
+</table>
+ </div>
+ </body>
+</html>
Propchange: sis/ip-review/DefaultConcatenatedOperation.xhtml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: sis/ip-review/DefaultConcatenatedOperation.xhtml
------------------------------------------------------------------------------
svn:mime-type = text/html
Added: sis/ip-review/rev/10796/DefaultConcatenatedOperation.xhtml
URL:
http://svn.apache.org/viewvc/sis/ip-review/rev/10796/DefaultConcatenatedOperation.xhtml?rev=1753371&view=auto
==============================================================================
--- sis/ip-review/rev/10796/DefaultConcatenatedOperation.xhtml (added)
+++ sis/ip-review/rev/10796/DefaultConcatenatedOperation.xhtml Tue Jul 19
12:13:03 2016
@@ -0,0 +1,89 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+ <head>
+ <meta charset="UTF-8"/>
+ <title>DefaultConcatenatedOperation changes for revisions
10795:10796</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>DefaultConcatenatedOperation changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto
reformat"</cite> tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import
ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters
is broken.
+This commit has been reverted, except for the removal of really unused imports
which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change
--ignore-all-space --ignore-eol-style" -r10795:10796
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultConcatenatedOperation.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2004, Institut de Recherche pour le
Développement</span>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2004, Institut de Recherche pour le
D�veloppement</span>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General
Public</pre></td></tr>
+<tr><td><pre>package org.geotools.referencing.operation;
+
+// J2SE dependencies
+<span class="del">import java.util.Map;</span>
+<span class="del">import java.util.List;</span>
+import java.util.ArrayList;
+import java.util.Collections;
+
+<span class="del">// OpenGIS dependencies</span>
+import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.SingleOperation;
+<span class="del">import
org.opengis.referencing.operation.CoordinateOperation;</span>
+<span class="del">import
org.opengis.referencing.operation.MathTransformFactory;</span>
+<span class="del">import
org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.referencing.IdentifiedObject;</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+<span class="del">import org.geotools.resources.cts.Resources;</span>
+<span class="del">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="del">import
org.geotools.referencing.operation.transform.ConcatenatedTransform;</span>
+
+<span class="del"></span>
+/**
+ * An ordered sequence of two or more single coordinate operations. The
sequence of operations is
+ * constrained by the requirement that the source coordinate reference system
of step</pre></td>
+<td><pre>package org.geotools.referencing.operation;
+
+// J2SE dependencies
+import java.util.ArrayList;
+import java.util.Collections;
+<span class="add">import java.util.List;</span>
+<span class="add">import java.util.Map;</span>
+
+<span class="add">import org.geotools.referencing.IdentifiedObject;</span>
+<span class="add">import
org.geotools.referencing.operation.transform.ConcatenatedTransform;</span>
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.cts.Resources;</span>
+import org.opengis.referencing.FactoryException;
+<span class="add">import
org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+<span class="add">import
org.opengis.referencing.operation.CoordinateOperation;</span>
+import org.opengis.referencing.operation.MathTransform;
+<span class="add">import
org.opengis.referencing.operation.MathTransformFactory;</span>
+import org.opengis.referencing.operation.SingleOperation;
+
+
+/**
+ * An ordered sequence of two or more single coordinate operations. The
sequence of operations is
+ * constrained by the requirement that the source coordinate reference system
of step</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Propchange: sis/ip-review/rev/10796/DefaultConcatenatedOperation.xhtml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: sis/ip-review/rev/10796/DefaultConcatenatedOperation.xhtml
------------------------------------------------------------------------------
svn:mime-type = text/html
Added: sis/ip-review/rev/20874/DefaultConcatenatedOperation.xhtml
URL:
http://svn.apache.org/viewvc/sis/ip-review/rev/20874/DefaultConcatenatedOperation.xhtml?rev=1753371&view=auto
==============================================================================
--- sis/ip-review/rev/20874/DefaultConcatenatedOperation.xhtml (added)
+++ sis/ip-review/rev/20874/DefaultConcatenatedOperation.xhtml Tue Jul 19
12:13:03 2016
@@ -0,0 +1,65 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml";>
+ <head>
+ <meta charset="UTF-8"/>
+ <title>DefaultConcatenatedOperation changes for revisions
20873:20874</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>DefaultConcatenatedOperation changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the <cite>"or (at your
option) any later version"</cite> clause
+must be keep in Geotk for every classes having contribution from a developer
other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions
are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change
--ignore-all-space --ignore-eol-style" -r20873:20874
http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultConcatenatedOperation.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee
(PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+<span class="del"> * License as published by the Free Software Foundation;
either</span>
+<span class="del"> * version 2.1 of the License, or (at your option) any
later version.</span>
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</pre></td>
+<td><pre>/*
+<span class="add"> * GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> * http://geotools.org</span>
+<span class="add"> * (C) 2004-2006, GeoTools Project Managment Committee
(PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+<span class="add"> * License as published by the Free Software
Foundation;</span>
+<span class="add"> * version 2.1 of the License.</span>
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty
of</pre></td></tr>
+<tr><td><pre>* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
the GNU
+* Lesser General Public License for more details.
+*
+<span class="del">* You should have received a copy of the GNU Lesser
General Public</span>
+<span class="del">* License along with this library; if not, write to the
Free Software</span>
+<span class="del">* Foundation, Inc., 59 Temple Place, Suite 330, Boston,
MA 02111-1307 USA</span>
+<span class="del">*</span>
+<span class="del">*</span>
+* This package contains documentation from OpenGIS specifications.
+* OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+* Lesser General Public License for more details.
+*
+* This package contains documentation from OpenGIS specifications.
+* OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Propchange: sis/ip-review/rev/20874/DefaultConcatenatedOperation.xhtml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: sis/ip-review/rev/20874/DefaultConcatenatedOperation.xhtml
------------------------------------------------------------------------------
svn:mime-type = text/html
