Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultCitationDate.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultCitationDate.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultCitationDate.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultCitationDate.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -46,6 +46,7 @@ import static org.apache.sis.internal.me * @version 0.3 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "CI_Date_Type", propOrder = { "date", "dateType" @@ -77,8 +78,8 @@ public class DefaultCitationDate extends /** * Constructs a citation date initialized to the given date. * - * @param date The reference date for the cited resource. - * @param dateType The event used for reference date. + * @param date the reference date for the cited resource. + * @param dateType the event used for reference date. */ public DefaultCitationDate(final Date date, final DateType dateType) { this.date = toMilliseconds(date); @@ -90,7 +91,7 @@ public class DefaultCitationDate extends * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(CitationDate) */ @@ -116,8 +117,8 @@ public class DefaultCitationDate extends * metadata contained in the given object are not recursively copied.</li> * </ul> * - * @param object The object to get as a SIS implementation, or {@code null} if none. - * @return A SIS implementation containing the values of the given object (may be the + * @param object the object to get as a SIS implementation, or {@code null} if none. + * @return a SIS implementation containing the values of the given object (may be the * given object itself), or {@code null} if the argument was null. */ public static DefaultCitationDate castOrCopy(final CitationDate object) { @@ -130,7 +131,7 @@ public class DefaultCitationDate extends /** * Returns the reference date for the cited resource. * - * @return Reference date for the cited resource, or {@code null}. + * @return reference date for the cited resource, or {@code null}. */ @Override @XmlElement(name = "date", required = true) @@ -141,7 +142,7 @@ public class DefaultCitationDate extends /** * Sets the reference date for the cited resource. * - * @param newValue The new date. + * @param newValue the new date. */ public void setDate(final Date newValue) { checkWritePermission(); @@ -151,7 +152,7 @@ public class DefaultCitationDate extends /** * Returns the event used for reference date. * - * @return Event used for reference date, or {@code null}. + * @return event used for reference date, or {@code null}. */ @Override @XmlElement(name = "dateType", required = true) @@ -162,7 +163,7 @@ public class DefaultCitationDate extends /** * Sets the event used for reference date. * - * @param newValue The new event. + * @param newValue the new event. */ public void setDateType(final DateType newValue) { checkWritePermission();
Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultContact.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultContact.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultContact.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultContact.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -59,6 +59,7 @@ import static org.opengis.annotation.Spe * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "CI_Contact_Type", propOrder = { "phone", "address", @@ -112,8 +113,8 @@ public class DefaultContact extends ISOM /** * Constructs a contact initialized to the specified online resource. * - * @param resource The on-line information that can be used to contact the individual or - * organization, or {@code null} if none. + * @param resource the on-line information that can be used to contact the individual or organization, + * or {@code null} if none. */ public DefaultContact(final OnlineResource resource) { this.onlineResources = singleton(resource, OnlineResource.class); @@ -124,7 +125,7 @@ public class DefaultContact extends ISOM * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(Contact) */ @@ -161,8 +162,8 @@ public class DefaultContact extends ISOM * metadata contained in the given object are not recursively copied.</li> * </ul> * - * @param object The object to get as a SIS implementation, or {@code null} if none. - * @return A SIS implementation containing the values of the given object (may be the + * @param object the object to get as a SIS implementation, or {@code null} if none. + * @return a SIS implementation containing the values of the given object (may be the * given object itself), or {@code null} if the argument was null. */ public static DefaultContact castOrCopy(final Contact object) { @@ -175,7 +176,7 @@ public class DefaultContact extends ISOM /** * Returns telephone numbers at which the organization or individual may be contacted. * - * @return Telephone numbers at which the organization or individual may be contacted. + * @return telephone numbers at which the organization or individual may be contacted. * * @since 0.5 */ @@ -187,7 +188,7 @@ public class DefaultContact extends ISOM /** * Sets telephone numbers at which the organization or individual may be contacted. * - * @param newValues The new telephones. + * @param newValues the new telephones. * * @since 0.5 */ @@ -221,7 +222,7 @@ public class DefaultContact extends ISOM * This method returns the first telephone number associated to {@link TelephoneType#VOICE} * or {@link TelephoneType#FACSIMILE FACSIMILE}. * - * @return Telephone numbers at which the organization or individual may be contacted, or {@code null}. + * @return telephone numbers at which the organization or individual may be contacted, or {@code null}. * * @deprecated As of ISO 19115:2014, replaced by {@link #getPhones()}. */ @@ -258,7 +259,7 @@ public class DefaultContact extends ISOM * Sets telephone numbers at which the organization or individual may be contacted. * This method delegates to {@link #setPhones(Collection)}. * - * @param newValue The new telephone, or {@code null} if none. + * @param newValue the new telephone, or {@code null} if none. * * @deprecated As of ISO 19115:2014, replaced by {@link #setPhones(Collection)}. */ @@ -284,7 +285,7 @@ public class DefaultContact extends ISOM /** * Returns the physical and email addresses at which the organization or individual may be contacted. * - * @return Physical and email addresses at which the organization or individual may be contacted, or {@code null}. + * @return physical and email addresses at which the organization or individual may be contacted, or {@code null}. * * @since 0.5 */ @@ -296,7 +297,7 @@ public class DefaultContact extends ISOM /** * Sets the physical and email addresses at which the organization or individual may be contacted. * - * @param newValues The new addresses. + * @param newValues the new addresses. * * @since 0.5 */ @@ -308,7 +309,7 @@ public class DefaultContact extends ISOM * Returns the physical and email address at which the organization or individual may be contacted. * This method returns the first {@link #getAddresses() adress} element, or null if none. * - * @return Physical and email address at which the organization or individual may be contacted, or {@code null}. + * @return physical and email address at which the organization or individual may be contacted, or {@code null}. * * @deprecated As of ISO 19115:2014, replaced by {@link #getAddresses()}. */ @@ -323,7 +324,7 @@ public class DefaultContact extends ISOM * Sets the physical and email address at which the organization or individual may be contacted. * This method delegates to {@link #setAddresses(Collection)}. * - * @param newValue The new address, or {@code null} if none. + * @param newValue the new address, or {@code null} if none. * * @deprecated As of ISO 19115:2014, replaced by {@link #setAddresses(Collection)}. */ @@ -335,7 +336,7 @@ public class DefaultContact extends ISOM /** * Returns on-line information that can be used to contact the individual or organization. * - * @return On-line information that can be used to contact the individual or organization. + * @return on-line information that can be used to contact the individual or organization. * * @since 0.5 */ @@ -347,7 +348,7 @@ public class DefaultContact extends ISOM /** * Sets on-line information that can be used to contact the individual or organization. * - * @param newValues The new online resources. + * @param newValues the new online resources. * * @since 0.5 */ @@ -359,7 +360,7 @@ public class DefaultContact extends ISOM * Returns on-line information that can be used to contact the individual or organization. * This method returns the first {@link #getOnlineResources() online resource} element, or null if none. * - * @return On-line information that can be used to contact the individual or organization, or {@code null}. + * @return on-line information that can be used to contact the individual or organization, or {@code null}. * * @deprecated As of ISO 19115:2014, replaced by {@link #getOnlineResources()}. */ @@ -374,7 +375,7 @@ public class DefaultContact extends ISOM * Sets on-line information that can be used to contact the individual or organization. * This method delegates to {@link #setOnlineResources(Collection)}. * - * @param newValue The new online resource, or {@code null} if none. + * @param newValue the new online resource, or {@code null} if none. * * @deprecated As of ISO 19115:2014, replaced by {@link #setOnlineResources(Collection)}. */ @@ -391,7 +392,7 @@ public class DefaultContact extends ISOM * This change will tentatively be applied in GeoAPI 4.0. * </div> * - * @return Time period when individuals can contact the organization or individual, or {@code null}. + * @return time period when individuals can contact the organization or individual. */ @Override @XmlElement(name = "hoursOfService") @@ -407,7 +408,7 @@ public class DefaultContact extends ISOM * This change will tentatively be applied in GeoAPI 4.0. * </div> * - * @param newValue The new hours of service, or {@code null} if none. + * @param newValue the new hours of service. */ public void setHoursOfService(final InternationalString newValue) { checkWritePermission(); @@ -417,7 +418,7 @@ public class DefaultContact extends ISOM /** * Returns supplemental instructions on how or when to contact the individual or organization. * - * @return Supplemental instructions on how or when to contact the individual or organization, or {@code null}. + * @return supplemental instructions on how or when to contact the individual or organization, or {@code null}. */ @Override @XmlElement(name = "contactInstructions") @@ -428,7 +429,7 @@ public class DefaultContact extends ISOM /** * Sets supplemental instructions on how or when to contact the individual or organization. * - * @param newValue The new contact instructions, or {@code null} if none. + * @param newValue the new contact instructions, or {@code null} if none. */ public void setContactInstructions(final InternationalString newValue) { checkWritePermission(); @@ -439,7 +440,7 @@ public class DefaultContact extends ISOM * Type of the contact. * Returns {@code null} if none. * - * @return Type of the contact, or {@code null} if none. + * @return type of the contact, or {@code null} if none. * * @since 0.5 */ @@ -452,7 +453,7 @@ public class DefaultContact extends ISOM /** * Sets new type of the contact. * - * @param newValue The new type of the contact. + * @param newValue the new type of the contact. * * @since 0.5 */ Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultIndividual.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultIndividual.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultIndividual.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultIndividual.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -55,6 +55,7 @@ import static org.opengis.annotation.Spe * @since 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "CI_Individual_Type", propOrder = { "positionName" }) @@ -80,9 +81,9 @@ public class DefaultIndividual extends A /** * Constructs an individual initialized to the specified values. * - * @param name Name of the individual. - * @param positionName Position of the individual in an organization. - * @param contactInfo Contact information for the individual. + * @param name name of the individual. + * @param positionName position of the individual in an organization. + * @param contactInfo contact information for the individual. */ public DefaultIndividual(final CharSequence name, final CharSequence positionName, @@ -97,7 +98,7 @@ public class DefaultIndividual extends A * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. */ public DefaultIndividual(final DefaultIndividual object) { super(object); @@ -109,7 +110,7 @@ public class DefaultIndividual extends A /** * Returns position of the individual in an organization, or {@code null} if none. * - * @return Position of the individual in an organization, or {@code null} if none. + * @return position of the individual in an organization, or {@code null} if none. */ @XmlElement(name = "positionName") @UML(identifier="positionName", obligation=CONDITIONAL, specification=ISO_19115) @@ -120,7 +121,7 @@ public class DefaultIndividual extends A /** * Sets a new position of the individual in an organization. * - * @param newValue The new position of the individual in an organization. + * @param newValue the new position of the individual in an organization. */ public void setPositionName(final InternationalString newValue) { checkWritePermission(); Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultOnlineResource.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultOnlineResource.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultOnlineResource.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultOnlineResource.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -50,6 +50,7 @@ import static org.opengis.annotation.Spe * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "CI_OnlineResource_Type", propOrder = { "linkage", "protocol", @@ -111,7 +112,7 @@ public class DefaultOnlineResource exten /** * Creates an on line resource initialized to the given URI. * - * @param linkage The location for on-line access using a Uniform Resource Locator address, + * @param linkage the location for on-line access using a Uniform Resource Locator address, * or {@code null} if none. */ public DefaultOnlineResource(final URI linkage) { @@ -123,7 +124,7 @@ public class DefaultOnlineResource exten * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(OnlineResource) */ @@ -156,8 +157,8 @@ public class DefaultOnlineResource exten * metadata contained in the given object are not recursively copied.</li> * </ul> * - * @param object The object to get as a SIS implementation, or {@code null} if none. - * @return A SIS implementation containing the values of the given object (may be the + * @param object the object to get as a SIS implementation, or {@code null} if none. + * @return a SIS implementation containing the values of the given object (may be the * given object itself), or {@code null} if the argument was null. */ public static DefaultOnlineResource castOrCopy(final OnlineResource object) { @@ -171,7 +172,7 @@ public class DefaultOnlineResource exten * Returns the name of an application profile that can be used with the online resource. * Returns {@code null} if none. * - * @return Application profile that can be used with the online resource, or {@code null}. + * @return application profile that can be used with the online resource, or {@code null}. */ @Override @XmlElement(name = "applicationProfile") @@ -182,7 +183,7 @@ public class DefaultOnlineResource exten /** * Sets the name of an application profile that can be used with the online resource. * - * @param newValue The new application profile. + * @param newValue the new application profile. */ public void setApplicationProfile(final String newValue) { checkWritePermission(); @@ -196,7 +197,7 @@ public class DefaultOnlineResource exten * The return type may be changed from {@code String} to {@code InternationalString} in GeoAPI 4.0. * </div> * - * @return Name of the online resource, or {@code null}. + * @return name of the online resource, or {@code null}. */ @Override @XmlElement(name = "name") @@ -211,7 +212,7 @@ public class DefaultOnlineResource exten * The argument type may be changed from {@code String} to {@code InternationalString} in GeoAPI 4.0. * </div> * - * @param newValue The new name, or {@code null} if none. + * @param newValue the new name, or {@code null} if none. */ public void setName(final String newValue) { checkWritePermission(); @@ -221,7 +222,7 @@ public class DefaultOnlineResource exten /** * Returns the detailed text description of what the online resource is/does. * - * @return Text description of what the online resource is/does, or {@code null}. + * @return text description of what the online resource is/does, or {@code null}. */ @Override @XmlElement(name = "description") @@ -232,7 +233,7 @@ public class DefaultOnlineResource exten /** * Sets the detailed text description of what the online resource is/does. * - * @param newValue The new description, or {@code null} if none. + * @param newValue the new description, or {@code null} if none. */ public void setDescription(final InternationalString newValue) { checkWritePermission(); @@ -242,7 +243,7 @@ public class DefaultOnlineResource exten /** * Returns the code for function performed by the online resource. * - * @return Function performed by the online resource, or {@code null}. + * @return function performed by the online resource, or {@code null}. */ @Override @XmlElement(name = "function") @@ -253,7 +254,7 @@ public class DefaultOnlineResource exten /** * Sets the code for function performed by the online resource. * - * @param newValue The new function, or {@code null} if none. + * @param newValue the new function, or {@code null} if none. */ public void setFunction(final OnLineFunction newValue) { checkWritePermission(); @@ -264,7 +265,7 @@ public class DefaultOnlineResource exten * Returns the location (address) for on-line access using a Uniform Resource Locator address or * similar addressing scheme. * - * @return Location for on-line access using a Uniform Resource Locator address or similar scheme, or {@code null}. + * @return location for on-line access using a Uniform Resource Locator address or similar scheme, or {@code null}. */ @Override @XmlElement(name = "linkage", required = true) @@ -276,7 +277,7 @@ public class DefaultOnlineResource exten * Sets the location (address) for on-line access using a Uniform Resource Locator address or * similar addressing scheme such as "{@code http://www.statkart.no/isotc211}";. * - * @param newValue The new linkage, or {@code null} if none. + * @param newValue the new linkage, or {@code null} if none. */ public void setLinkage(final URI newValue) { checkWritePermission(); @@ -290,7 +291,7 @@ public class DefaultOnlineResource exten * ftp, http get KVP, http POST, <i>etc</i>. * </div> * - * @return Connection protocol to be used, or {@code null}. + * @return connection protocol to be used, or {@code null}. */ @Override @XmlElement(name = "protocol") @@ -301,7 +302,7 @@ public class DefaultOnlineResource exten /** * Sets the connection protocol to be used. * - * @param newValue The new protocol, or {@code null} if none. + * @param newValue the new protocol, or {@code null} if none. */ public void setProtocol(final String newValue) { checkWritePermission(); @@ -334,7 +335,7 @@ public class DefaultOnlineResource exten /** * Sets the request to be used. * - * @param newValue The new request, or {@code null} if none. + * @param newValue the new request, or {@code null} if none. * * @since 0.5 */ Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultOrganisation.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultOrganisation.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultOrganisation.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultOrganisation.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -56,6 +56,7 @@ import static org.opengis.annotation.Spe * @since 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "CI_Organisation_Type", propOrder = { "logo", "individual" @@ -87,10 +88,10 @@ public class DefaultOrganisation extends /** * Constructs an organization initialized to the specified values. * - * @param name Name of the organization, or {@code null} if none. - * @param logo Graphic identifying the organization, or {@code null} if none. - * @param individual Position of the individual in an organization, or {@code null} if none. - * @param contactInfo Contact information for the organization, or {@code null} if none. + * @param name name of the organization, or {@code null} if none. + * @param logo graphic identifying the organization, or {@code null} if none. + * @param individual position of the individual in an organization, or {@code null} if none. + * @param contactInfo contact information for the organization, or {@code null} if none. */ public DefaultOrganisation(final CharSequence name, final BrowseGraphic logo, @@ -107,7 +108,7 @@ public class DefaultOrganisation extends * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. */ public DefaultOrganisation(final DefaultOrganisation object) { super(object); @@ -120,7 +121,7 @@ public class DefaultOrganisation extends /** * Returns the graphics identifying organization. * - * @return Graphics identifying organization, or an empty collection if there is none. + * @return graphics identifying organization, or an empty collection if there is none. */ @XmlElement(name = "logo") @UML(identifier="logo", obligation=CONDITIONAL, specification=ISO_19115) @@ -131,7 +132,7 @@ public class DefaultOrganisation extends /** * Sets the graphics identifying organisation. * - * @param newValues The new graphics identifying organization. + * @param newValues the new graphics identifying organization. */ public void setLogo(final Collection<? extends BrowseGraphic> newValues) { logo = writeCollection(newValues, logo, BrowseGraphic.class); @@ -145,7 +146,7 @@ public class DefaultOrganisation extends * when GeoAPI will provide it (tentatively in GeoAPI 3.1). * </div> * - * @return Individuals in the named organization, or an empty collection. + * @return individuals in the named organization, or an empty collection. */ @XmlElement(name = "individual") @UML(identifier="individual", obligation=OPTIONAL, specification=ISO_19115) @@ -161,7 +162,7 @@ public class DefaultOrganisation extends * when GeoAPI will provide it (tentatively in GeoAPI 3.1). * </div> * - * @param newValues The new individuals in the named organization. + * @param newValues the new individuals in the named organization. */ public void setIndividual(final Collection<? extends DefaultIndividual> newValues) { individual = writeCollection(newValues, individual, DefaultIndividual.class); Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultResponsibility.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultResponsibility.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultResponsibility.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultResponsibility.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -59,6 +59,7 @@ import static org.opengis.annotation.Spe * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "CI_Responsibility_Type", propOrder = { /// "role", /// "extents", @@ -99,9 +100,9 @@ public class DefaultResponsibility exten /** * Constructs a responsibility initialized to the specified values. * - * @param role Function performed by the responsible party, or {@code null}. - * @param extent Spatial or temporal extent of the role, or {@code null}. - * @param party Information about the party, or {@code null}. + * @param role function performed by the responsible party, or {@code null}. + * @param extent spatial or temporal extent of the role, or {@code null}. + * @param party information about the party, or {@code null}. */ public DefaultResponsibility(final Role role, final Extent extent, final AbstractParty party) { this.role = role; @@ -114,7 +115,7 @@ public class DefaultResponsibility exten * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. */ public DefaultResponsibility(final DefaultResponsibility object) { super(object); @@ -143,7 +144,7 @@ public class DefaultResponsibility exten /** * Returns the function performed by the responsible party. * - * @return Function performed by the responsible party. + * @return function performed by the responsible party. */ /// @XmlElement(name = "role", required = true) @UML(identifier="role", obligation=MANDATORY, specification=ISO_19115) @@ -154,7 +155,7 @@ public class DefaultResponsibility exten /** * Sets the function performed by the responsible party. * - * @param newValue The new role, or {@code null} if none. + * @param newValue the new role, or {@code null} if none. */ public void setRole(final Role newValue) { checkWritePermission(); @@ -164,7 +165,7 @@ public class DefaultResponsibility exten /** * Returns the spatial or temporal extents of the role. * - * @return The spatial or temporal extents of the role. + * @return the spatial or temporal extents of the role. */ /// @XmlElement(name = "extent") @UML(identifier="extent", obligation=OPTIONAL, specification=ISO_19115) @@ -175,7 +176,7 @@ public class DefaultResponsibility exten /** * Sets the spatial and temporal extents of the role. * - * @param newValues The new spatial and temporal extents of the role. + * @param newValues the new spatial and temporal extents of the role. */ public void setExtents(final Collection<? extends Extent> newValues) { extents = writeCollection(newValues, extents, Extent.class); @@ -189,7 +190,7 @@ public class DefaultResponsibility exten * when GeoAPI will provide it (tentatively in GeoAPI 3.1). * </div> * - * @return Information about the parties. + * @return information about the parties. */ /// @XmlElement(name = "party", required = true) @UML(identifier="party", obligation=MANDATORY, specification=ISO_19115) @@ -205,7 +206,7 @@ public class DefaultResponsibility exten * when GeoAPI will provide it (tentatively in GeoAPI 3.1). * </div> * - * @param newValues New information about the parties. + * @param newValues new information about the parties. */ public void setParties(final Collection<? extends AbstractParty> newValues) { parties = writeCollection(newValues, parties, AbstractParty.class); Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultResponsibleParty.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultResponsibleParty.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultResponsibleParty.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultResponsibleParty.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -47,6 +47,7 @@ import org.apache.sis.internal.metadata. * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "CI_ResponsibleParty_Type", propOrder = { "individualName", "organisationName", @@ -70,7 +71,7 @@ public class DefaultResponsibleParty ext /** * Constructs a responsibility party with the given role. * - * @param role The function performed by the responsible party, or {@code null}. + * @param role the function performed by the responsible party, or {@code null}. */ public DefaultResponsibleParty(final Role role) { super(role, null, null); @@ -81,7 +82,7 @@ public class DefaultResponsibleParty ext * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. */ public DefaultResponsibleParty(final DefaultResponsibility object) { super(object); @@ -118,8 +119,8 @@ public class DefaultResponsibleParty ext * metadata contained in the given object are not recursively copied.</li> * </ul> * - * @param object The object to get as a SIS implementation, or {@code null} if none. - * @return A SIS implementation containing the values of the given object (may be the + * @param object the object to get as a SIS implementation, or {@code null} if none. + * @return a SIS implementation containing the values of the given object (may be the * given object itself), or {@code null} if the argument was null. */ public static DefaultResponsibleParty castOrCopy(final ResponsibleParty object) { @@ -135,7 +136,7 @@ public class DefaultResponsibleParty ext * reader. * * @param position {@code true} for returning the position name instead than individual name. - * @return The name or position of the first individual, or {@code null}. + * @return the name or position of the first individual, or {@code null}. * * @see #getIndividualName() * @see #getPositionName() @@ -160,7 +161,7 @@ public class DefaultResponsibleParty ext * Returns the name of the first party of the given type, or {@code null} if none. * * @param position {@code true} for returning the position name instead than individual name. - * @return The name or position of the first individual, or {@code null}. + * @return the name or position of the first individual, or {@code null}. * * @see #getOrganisationName() * @see #getIndividualName() @@ -208,7 +209,7 @@ public class DefaultResponsibleParty ext return true; } } - return name == null; // If no party and name is null, there is nothing to set. + return name == null; // If no party and name is null, there is nothing to set. } /** @@ -220,7 +221,7 @@ public class DefaultResponsibleParty ext * {@linkplain #getParties() parties}. If no individual is found in the parties, then this method fallbacks * on the first {@linkplain Organisation#getIndividual() organisation member}.</p> * - * @return Name, surname, given name and title of the responsible person, or {@code null}. + * @return name, surname, given name and title of the responsible person, or {@code null}. * * @deprecated As of ISO 19115:2014, replaced by {@code getName()} in {@link DefaultIndividual}. */ @@ -240,7 +241,7 @@ public class DefaultResponsibleParty ext * <p>This implementation sets the name of the first {@link Individual} found in the collection of * {@linkplain #getParties() parties}, or create a new individual if no existing instance was found.</p> * - * @param newValue The new individual name, or {@code null} if none. + * @param newValue the new individual name, or {@code null} if none. * * @deprecated As of ISO 19115:2014, replaced by {@code setName(InternationalString)} in {@link DefaultIndividual}. */ @@ -259,7 +260,7 @@ public class DefaultResponsibleParty ext * <p>This implementation returns the name of the first {@link Organisation} * found in the collection of {@linkplain #getParties() parties}.</p> * - * @return Name of the responsible organization, or {@code null}. + * @return name of the responsible organization, or {@code null}. * * @deprecated As of ISO 19115:2014, replaced by {@code getName()} in {@link DefaultOrganisation}. */ @@ -278,7 +279,7 @@ public class DefaultResponsibleParty ext * <p>This implementation sets the name of the first {@link Organisation} found in the collection of * {@linkplain #getParties() parties}, or create a new organization if no existing instance was found.</p> * - * @param newValue The new organization name, or {@code null} if none. + * @param newValue the new organization name, or {@code null} if none. * * @deprecated As of ISO 19115:2014, replaced by {@code setName(InternationalString)} in {@link DefaultOrganisation}. */ @@ -298,7 +299,7 @@ public class DefaultResponsibleParty ext * {@linkplain #getParties() parties}. If no individual is found in the parties, then this method fallbacks * on the first {@linkplain Organisation#getIndividual() organisation member}.</p> * - * @return Role or position of the responsible person, or {@code null} + * @return role or position of the responsible person, or {@code null} * * @deprecated As of ISO 19115:2014, replaced by {@link DefaultIndividual#getPositionName()}. */ @@ -317,7 +318,7 @@ public class DefaultResponsibleParty ext * <p>This implementation sets the position name of the first {@link Individual} found in the collection of * {@linkplain #getParties() parties}, or create a new individual if no existing instance was found.</p> * - * @param newValue The new position name, or {@code null} if none. + * @param newValue the new position name, or {@code null} if none. * * @deprecated As of ISO 19115:2014, replaced by {@link DefaultIndividual#setPositionName(InternationalString)}. */ @@ -334,7 +335,7 @@ public class DefaultResponsibleParty ext * <p>This implementation returns the first non-null contact found in the collection of * {@linkplain #getParties() parties}.</p> * - * @return Address of the responsible party, or {@code null}. + * @return address of the responsible party, or {@code null}. * * @deprecated As of ISO 19115:2014, replaced by {@link AbstractParty#getContactInfo()}. */ @@ -364,7 +365,7 @@ public class DefaultResponsibleParty ext * <p>This implementation sets the contact info in the first party found in the collection of * {@linkplain #getParties() parties}.</p> * - * @param newValue The new contact info, or {@code null} if none. + * @param newValue the new contact info, or {@code null} if none. * * @deprecated As of ISO 19115:2014, replaced by {@link AbstractParty#setContactInfo(Collection)}. */ @@ -392,8 +393,8 @@ public class DefaultResponsibleParty ext /** * Returns the function performed by the responsible party. * - * @return Function performed by the responsible party. - */ + * @return function performed by the responsible party. + */ @Override @XmlElement(name = "role", required = true) public Role getRole() { @@ -403,7 +404,7 @@ public class DefaultResponsibleParty ext /** * Sets the function performed by the responsible party. * - * @param newValue The new role. + * @param newValue the new role. */ @Override public void setRole(final Role newValue) { Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultSeries.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultSeries.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultSeries.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultSeries.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -43,6 +43,7 @@ import org.apache.sis.util.iso.Types; * @version 0.3 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "CI_Series_Type", propOrder = { "name", "issueIdentification", @@ -79,7 +80,7 @@ public class DefaultSeries extends ISOMe /** * Constructs a series with the specified name. * - * @param name The name of the series of which the dataset is a part, or {@code null}. + * @param name the name of the series of which the dataset is a part, or {@code null}. */ public DefaultSeries(final CharSequence name) { this.name = Types.toInternationalString(name); @@ -90,7 +91,7 @@ public class DefaultSeries extends ISOMe * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(Series) */ @@ -117,8 +118,8 @@ public class DefaultSeries extends ISOMe * metadata contained in the given object are not recursively copied.</li> * </ul> * - * @param object The object to get as a SIS implementation, or {@code null} if none. - * @return A SIS implementation containing the values of the given object (may be the + * @param object the object to get as a SIS implementation, or {@code null} if none. + * @return a SIS implementation containing the values of the given object (may be the * given object itself), or {@code null} if the argument was null. */ public static DefaultSeries castOrCopy(final Series object) { @@ -131,7 +132,7 @@ public class DefaultSeries extends ISOMe /** * Returns the name of the series, or aggregate dataset, of which the dataset is a part. * - * @return The name of the series or aggregate dataset, or {@code null}. + * @return the name of the series or aggregate dataset, or {@code null}. */ @Override @XmlElement(name = "name") @@ -142,7 +143,7 @@ public class DefaultSeries extends ISOMe /** * Sets the name of the series, or aggregate dataset, of which the dataset is a part. * - * @param newValue The new name, or {@code null} if none. + * @param newValue the new name, or {@code null} if none. */ public void setName(final InternationalString newValue) { checkWritePermission(); @@ -157,7 +158,7 @@ public class DefaultSeries extends ISOMe * This change will be tentatively applied in GeoAPI 4.0. * </div> * - * @return Information identifying the issue of the series, or {@code null}. + * @return information identifying the issue of the series, or {@code null}. */ @Override @XmlElement(name = "issueIdentification") @@ -173,7 +174,7 @@ public class DefaultSeries extends ISOMe * This change will be tentatively applied in GeoAPI 4.0. * </div> * - * @param newValue The new issue identification, or {@code null} if none. + * @param newValue the new issue identification, or {@code null} if none. */ public void setIssueIdentification(final String newValue) { checkWritePermission(); @@ -188,7 +189,7 @@ public class DefaultSeries extends ISOMe * This change will be tentatively applied in GeoAPI 4.0. * </div> * - * @return Details on which pages of the publication the article was published, or {@code null}. + * @return details on which pages of the publication the article was published, or {@code null}. */ @Override @XmlElement(name = "page") @@ -204,7 +205,7 @@ public class DefaultSeries extends ISOMe * This change will be tentatively applied in GeoAPI 4.0. * </div> * - * @param newValue The new page, or {@code null} if none. + * @param newValue the new page, or {@code null} if none. */ public void setPage(final String newValue) { checkWritePermission(); Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultTelephone.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultTelephone.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultTelephone.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/DefaultTelephone.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -68,6 +68,7 @@ import static org.opengis.annotation.Spe * * @see DefaultContact#getPhones() */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "CI_Telephone_Type", propOrder = { "voices", "facsimiles" @@ -98,8 +99,8 @@ public class DefaultTelephone extends IS /** * Constructs a telephone with the given number and type. * - * @param number The telephone number, or {@code null}. - * @param numberType The type of telephone number, or {@code null}. + * @param number the telephone number, or {@code null}. + * @param numberType the type of telephone number, or {@code null}. * * @since 0.5 */ @@ -113,7 +114,7 @@ public class DefaultTelephone extends IS * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(Telephone) */ @@ -144,8 +145,8 @@ public class DefaultTelephone extends IS * metadata contained in the given object are not recursively copied.</li> * </ul> * - * @param object The object to get as a SIS implementation, or {@code null} if none. - * @return A SIS implementation containing the values of the given object (may be the + * @param object the object to get as a SIS implementation, or {@code null} if none. + * @return a SIS implementation containing the values of the given object (may be the * given object itself), or {@code null} if the argument was null. */ public static DefaultTelephone castOrCopy(final Telephone object) { @@ -158,7 +159,7 @@ public class DefaultTelephone extends IS /** * Returns the telephone number by which individuals can contact responsible organization or individual. * - * @return Telephone number by which individuals can contact responsible organization or individual. + * @return telephone number by which individuals can contact responsible organization or individual. * * @since 0.5 */ @@ -171,7 +172,7 @@ public class DefaultTelephone extends IS /** * Sets the telephone number by which individuals can contact responsible organization or individual. * - * @param newValue The new telephone number by which individuals can contact responsible organization or individual. + * @param newValue the new telephone number by which individuals can contact responsible organization or individual. * * @since 0.5 */ @@ -189,7 +190,7 @@ public class DefaultTelephone extends IS * when GeoAPI will provide it (tentatively in GeoAPI 3.1). * </div> * - * @return Type of telephone number, or {@code null} if none. + * @return type of telephone number, or {@code null} if none. * * @since 0.5 */ @@ -232,7 +233,7 @@ public class DefaultTelephone extends IS * } * </div> * - * @param newValue The new type of telephone number. + * @param newValue the new type of telephone number. * * @since 0.5 */ @@ -262,7 +263,7 @@ public class DefaultTelephone extends IS * * <p>This method will be removed after we removed the deprecated public methods.</p> * - * @param phones The collection which should contains this telephone number. + * @param phones the collection which should contains this telephone number. * @return {@code this}, or a copy of this instance if we conservatively choose to not modify this instance. */ final DefaultTelephone setOwner(final Collection<Telephone> phones) { @@ -301,7 +302,7 @@ public class DefaultTelephone extends IS * This method searches in the {@linkplain DefaultContact#getPhones() contact phones}, if the contact that own * this phone is known. * - * @return Telephone numbers by which individuals can speak to the responsible organization or individual. + * @return telephone numbers by which individuals can speak to the responsible organization or individual. * * @deprecated As of ISO 19115:2014, replaced by a {@linkplain #getNumber() number} * with {@link TelephoneType#VOICE}. @@ -318,7 +319,7 @@ public class DefaultTelephone extends IS * This method writes in the {@linkplain DefaultContact#getPhones() contact phones}, if the contact that own * this phone is known. * - * @param newValues The new telephone numbers, or {@code null} if none. + * @param newValues the new telephone numbers, or {@code null} if none. * * @deprecated As of ISO 19115:2014, replaced by a {@linkplain #setNumber(String) number} * with {@link TelephoneType#VOICE}. @@ -333,7 +334,7 @@ public class DefaultTelephone extends IS * This method searches in the {@linkplain DefaultContact#getPhones() contact phones}, if the contact * that own this phone is known. * - * @return Telephone numbers of a facsimile machine for the responsible organization or individual. + * @return telephone numbers of a facsimile machine for the responsible organization or individual. * * @deprecated As of ISO 19115:2014, replaced by a {@linkplain #getNumber() number} * with {@link TelephoneType#FACSIMILE}. @@ -350,7 +351,7 @@ public class DefaultTelephone extends IS * This method writes in the {@linkplain DefaultContact#getPhones() contact phones}, if the contact * that own this phone is known. * - * @param newValues The new telephone number, or {@code null} if none. + * @param newValues the new telephone number, or {@code null} if none. * * @deprecated As of ISO 19115:2014, replaced by a {@linkplain #setNumber(String) number} * with {@link TelephoneType#FACSIMILE}. Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/LegacyTelephones.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/LegacyTelephones.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/LegacyTelephones.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/citation/LegacyTelephones.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -95,12 +95,13 @@ final class LegacyTelephones extends Leg * will be set in that element. We test only the first element because {@link DefaultTelephone#getOwner()} * initialize new collections as collection containing {@code DefaultTelephone.this}. * - * @param value The telephone number to add. + * @param value the telephone number to add. * @return {@code true} if the element has been added. */ @Override public boolean add(final String value) { - if (value == null || value.isEmpty()) { // Null value happen with empty XML elements like <gco:CharacterString/> + // Null value happen with empty XML elements like <gco:CharacterString/> + if (value == null || value.isEmpty()) { return false; } final Iterator<Telephone> it = elements.iterator(); Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultConstraints.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultConstraints.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultConstraints.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultConstraints.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -57,6 +57,7 @@ import static org.opengis.annotation.Spe * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_Constraints_Type" /*, propOrder = { "useLimitation", "constraintApplicationScope", @@ -116,7 +117,7 @@ public class DefaultConstraints extends /** * Constructs a new constraints with the given {@linkplain #getUseLimitations() use limitation}. * - * @param useLimitation The use limitation, or {@code null} if none. + * @param useLimitation the use limitation, or {@code null} if none. */ public DefaultConstraints(final CharSequence useLimitation) { useLimitations = singleton(Types.toInternationalString(useLimitation), InternationalString.class); @@ -127,7 +128,7 @@ public class DefaultConstraints extends * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object the metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(Constraints) */ Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultLegalConstraints.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultLegalConstraints.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultLegalConstraints.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultLegalConstraints.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -49,6 +49,7 @@ import org.opengis.metadata.constraint.L * @version 0.3 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_LegalConstraints_Type", propOrder = { "accessConstraints", "useConstraints", @@ -90,7 +91,7 @@ public class DefaultLegalConstraints ext /** * Constructs a new constraints with the given {@linkplain #getUseLimitations() use limitation}. * - * @param useLimitation The use limitation, or {@code null} if none. + * @param useLimitation the use limitation, or {@code null} if none. */ public DefaultLegalConstraints(final CharSequence useLimitation) { super(useLimitation); @@ -102,7 +103,7 @@ public class DefaultLegalConstraints ext * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(LegalConstraints) */ @@ -129,8 +130,8 @@ public class DefaultLegalConstraints ext * metadata contained in the given object are not recursively copied.</li> * </ul> * - * @param object The object to get as a SIS implementation, or {@code null} if none. - * @return A SIS implementation containing the values of the given object (may be the + * @param object the object to get as a SIS implementation, or {@code null} if none. + * @return a SIS implementation containing the values of the given object (may be the * given object itself), or {@code null} if the argument was null. */ public static DefaultLegalConstraints castOrCopy(final LegalConstraints object) { @@ -144,7 +145,7 @@ public class DefaultLegalConstraints ext * Returns the access constraints applied to assure the protection of privacy or intellectual property, * and any special restrictions or limitations on obtaining the resource. * - * @return Access constraints applied to assure the protection of privacy or intellectual property. + * @return access constraints applied to assure the protection of privacy or intellectual property. */ @Override @XmlElement(name = "accessConstraints") @@ -156,7 +157,7 @@ public class DefaultLegalConstraints ext * Sets the access constraints applied to assure the protection of privacy or intellectual property, * and any special restrictions or limitations on obtaining the resource. * - * @param newValues The new access constraints. + * @param newValues the new access constraints. */ public void setAccessConstraints(final Collection<? extends Restriction> newValues) { accessConstraints = writeCollection(newValues, accessConstraints, Restriction.class); @@ -166,7 +167,7 @@ public class DefaultLegalConstraints ext * Returns the constraints applied to assure the protection of privacy or intellectual property, * and any special restrictions or limitations or warnings on using the resource. * - * @return Constraints applied to assure the protection of privacy or intellectual property. + * @return constraints applied to assure the protection of privacy or intellectual property. */ @Override @XmlElement(name = "useConstraints") @@ -178,7 +179,7 @@ public class DefaultLegalConstraints ext * Sets the constraints applied to assure the protection of privacy or intellectual property, * and any special restrictions or limitations or warnings on using the resource. * - * @param newValues The new use constraints. + * @param newValues the new use constraints. */ public void setUseConstraints(final Collection<? extends Restriction> newValues) { useConstraints = writeCollection(newValues, useConstraints, Restriction.class); @@ -190,7 +191,7 @@ public class DefaultLegalConstraints ext * or {@linkplain #getUseConstraints() use constraints} declares * {@linkplain Restriction#OTHER_RESTRICTIONS other restrictions}. * - * @return Other restrictions and legal prerequisites for accessing and using the resource. + * @return other restrictions and legal prerequisites for accessing and using the resource. */ @Override @XmlElement(name = "otherConstraints") Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultReleasability.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultReleasability.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultReleasability.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultReleasability.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -56,6 +56,7 @@ import static org.opengis.annotation.Spe * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_Releasability_Type", propOrder = { "addressees", "statement", @@ -95,7 +96,7 @@ public class DefaultReleasability extend * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(Releasability) */ @@ -116,7 +117,7 @@ public class DefaultReleasability extend * when GeoAPI will provide it (tentatively in GeoAPI 3.1). * </div> * - * @return Parties to which the release statement applies. + * @return parties to which the release statement applies. */ @XmlElement(name = "addressee") @UML(identifier="addressee", obligation=OPTIONAL, specification=ISO_19115) @@ -132,7 +133,7 @@ public class DefaultReleasability extend * when GeoAPI will provide it (tentatively in GeoAPI 3.1). * </div> * - * @param newValues The new parties. + * @param newValues the new parties. */ public void getAddressees(final Collection<? extends DefaultResponsibility> newValues) { addressees = writeCollection(newValues, addressees, DefaultResponsibility.class); @@ -141,7 +142,7 @@ public class DefaultReleasability extend /** * Returns the release statement. * - * @return Release statement, or {@code null} if none. + * @return release statement, or {@code null} if none. */ @XmlElement(name = "statement") @UML(identifier="statement", obligation=OPTIONAL, specification=ISO_19115) @@ -152,7 +153,7 @@ public class DefaultReleasability extend /** * Sets the release statement. * - * @param newValue The new release statement. + * @param newValue the new release statement. */ public void setStatement(final InternationalString newValue) { checkWritePermission(); @@ -162,7 +163,7 @@ public class DefaultReleasability extend /** * Components in determining releasability. * - * @return Components in determining releasability. + * @return components in determining releasability. */ @XmlElement(name = "disseminationConstraints") @UML(identifier="disseminationConstraints", obligation=OPTIONAL, specification=ISO_19115) @@ -173,7 +174,7 @@ public class DefaultReleasability extend /** * Sets the components in determining releasability. * - * @param newValues The new components. + * @param newValues the new components. */ public void getDisseminationConstraints(final Collection<? extends Restriction> newValues) { disseminationConstraints = writeCollection(newValues, disseminationConstraints, Restriction.class); Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultSecurityConstraints.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultSecurityConstraints.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultSecurityConstraints.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/constraint/DefaultSecurityConstraints.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -43,6 +43,7 @@ import org.opengis.metadata.constraint.S * @version 0.3 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_SecurityConstraints_Type", propOrder = { "classification", "userNote", @@ -86,7 +87,7 @@ public class DefaultSecurityConstraints /** * Constructs a new constraints with the given {@linkplain #getUseLimitations() use limitation}. * - * @param useLimitation The use limitation, or {@code null} if none. + * @param useLimitation the use limitation, or {@code null} if none. */ public DefaultSecurityConstraints(final CharSequence useLimitation) { super(useLimitation); @@ -95,7 +96,7 @@ public class DefaultSecurityConstraints /** * Creates a security constraints initialized with the specified classification. * - * @param classification The name of the handling restrictions on the resource, or {@code null}. + * @param classification the name of the handling restrictions on the resource, or {@code null}. */ public DefaultSecurityConstraints(final Classification classification) { this.classification = classification; @@ -106,7 +107,7 @@ public class DefaultSecurityConstraints * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(SecurityConstraints) */ @@ -134,8 +135,8 @@ public class DefaultSecurityConstraints * metadata contained in the given object are not recursively copied.</li> * </ul> * - * @param object The object to get as a SIS implementation, or {@code null} if none. - * @return A SIS implementation containing the values of the given object (may be the + * @param object the object to get as a SIS implementation, or {@code null} if none. + * @return a SIS implementation containing the values of the given object (may be the * given object itself), or {@code null} if the argument was null. */ public static DefaultSecurityConstraints castOrCopy(final SecurityConstraints object) { @@ -148,7 +149,7 @@ public class DefaultSecurityConstraints /** * Returns the name of the handling restrictions on the resource. * - * @return Name of the handling restrictions on the resource, or {@code null}. + * @return name of the handling restrictions on the resource, or {@code null}. */ @Override @XmlElement(name = "classification", required = true) @@ -159,7 +160,7 @@ public class DefaultSecurityConstraints /** * Sets the name of the handling restrictions on the resource. * - * @param newValue The new classification. + * @param newValue the new classification. */ public void setClassification(final Classification newValue) { checkWritePermission(); @@ -170,7 +171,7 @@ public class DefaultSecurityConstraints * Returns the explanation of the application of the legal constraints or other restrictions and legal * prerequisites for obtaining and using the resource. * - * @return Explanation of the application of the legal constraints, or {@code null}. + * @return explanation of the application of the legal constraints, or {@code null}. */ @Override @XmlElement(name = "userNote") @@ -182,7 +183,7 @@ public class DefaultSecurityConstraints * Sets the explanation of the application of the legal constraints or other restrictions and legal * prerequisites for obtaining and using the resource. * - * @param newValue The new user note. + * @param newValue the new user note. */ public void setUserNote(final InternationalString newValue) { checkWritePermission(); @@ -192,7 +193,7 @@ public class DefaultSecurityConstraints /** * Returns the name of the classification system. * - * @return Name of the classification system, or {@code null}. + * @return name of the classification system, or {@code null}. */ @Override @XmlElement(name = "classificationSystem") @@ -203,7 +204,7 @@ public class DefaultSecurityConstraints /** * Sets the name of the classification system. * - * @param newValue The new classification system. + * @param newValue the new classification system. */ public void setClassificationSystem(final InternationalString newValue) { checkWritePermission(); @@ -213,7 +214,7 @@ public class DefaultSecurityConstraints /** * Returns the additional information about the restrictions on handling the resource. * - * @return Additional information about the restrictions, or {@code null}. + * @return additional information about the restrictions, or {@code null}. */ @Override @XmlElement(name = "handlingDescription") @@ -224,7 +225,7 @@ public class DefaultSecurityConstraints /** * Sets the additional information about the restrictions on handling the resource. * - * @param newValue The new handling description. + * @param newValue the new handling description. */ public void setHandlingDescription(final InternationalString newValue) { checkWritePermission(); Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/AbstractContentInformation.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/AbstractContentInformation.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/AbstractContentInformation.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/AbstractContentInformation.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -44,6 +44,7 @@ import org.apache.sis.metadata.iso.ISOMe * @version 0.3 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "AbstractMD_ContentInformation_Type") @XmlRootElement(name = "MD_ContentInformation") @XmlSeeAlso({ Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultAttributeGroup.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultAttributeGroup.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultAttributeGroup.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultAttributeGroup.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -58,6 +58,7 @@ import static org.opengis.annotation.Spe * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_AttributeGroup_Type", propOrder = { "contentType", "attribute" @@ -89,8 +90,8 @@ public class DefaultAttributeGroup exten /** * Constructs an attribute group initialized to the given values. * - * @param contentType Type of information represented by the value, or {@code null}. - * @param attribute The attribute, or {@code null}. + * @param contentType type of information represented by the value, or {@code null}. + * @param attribute the attribute, or {@code null}. */ public DefaultAttributeGroup(final CoverageContentType contentType, final RangeDimension attribute) { contentTypes = singleton(contentType, CoverageContentType.class); @@ -102,7 +103,7 @@ public class DefaultAttributeGroup exten * This is a <cite>shallow</cite> copy constructor, since the other metadata contained in the * given object are not recursively copied. * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(AttributeGroup) */ @@ -117,7 +118,7 @@ public class DefaultAttributeGroup exten /** * Returns the types of information represented by the value(s). * - * @return The types of information represented by the value(s). + * @return the types of information represented by the value(s). */ @XmlElement(name = "contentType", required = true) @UML(identifier="contentType", obligation=MANDATORY, specification=ISO_19115) @@ -128,7 +129,7 @@ public class DefaultAttributeGroup exten /** * Sets the types of information represented by the value(s). * - * @param newValues The new types of information. + * @param newValues the new types of information. */ public void setContentTypes(final Collection<? extends CoverageContentType> newValues) { contentTypes = writeCollection(newValues, contentTypes, CoverageContentType.class); @@ -137,7 +138,7 @@ public class DefaultAttributeGroup exten /** * Returns information on an attribute of the resource. * - * @return Information on an attribute of the resource. + * @return information on an attribute of the resource. */ @XmlElement(name = "attribute") @UML(identifier="attribute", obligation=OPTIONAL, specification=ISO_19115) @@ -148,7 +149,7 @@ public class DefaultAttributeGroup exten /** * Sets information on an attribute of the resource. * - * @param newValues The new attributes. + * @param newValues the new attributes. */ public void setAttributes(final Collection<? extends RangeDimension> newValues) { attributes = writeCollection(newValues, attributes, RangeDimension.class); Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultBand.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultBand.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultBand.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultBand.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -57,6 +57,7 @@ import static org.opengis.annotation.Spe * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_Band_Type", propOrder = { "peakResponse", "bitsPerValue", @@ -135,7 +136,7 @@ public class DefaultBand extends Default * metadata instances can also be obtained by unmarshalling an invalid XML document. * </div> * - * @param object The metadata to copy values from, or {@code null} if none. + * @param object the metadata to copy values from, or {@code null} if none. * * @see #castOrCopy(Band) */ @@ -170,8 +171,8 @@ public class DefaultBand extends Default * metadata contained in the given object are not recursively copied.</li> * </ul> * - * @param object The object to get as a SIS implementation, or {@code null} if none. - * @return A SIS implementation containing the values of the given object (may be the + * @param object the object to get as a SIS implementation, or {@code null} if none. + * @return a SIS implementation containing the values of the given object (may be the * given object itself), or {@code null} if the argument was null. */ public static DefaultBand castOrCopy(final Band object) { @@ -200,7 +201,7 @@ public class DefaultBand extends Default /** * Sets the shortest wavelength that the sensor is capable of collecting within a designated band. * - * @param newValue The new shortest wavelength, or {@code null}. + * @param newValue the new shortest wavelength, or {@code null}. * @throws IllegalArgumentException if the given value is negative. * * @since 0.5 @@ -216,7 +217,7 @@ public class DefaultBand extends Default * Returns the longest wavelength that the sensor is capable of collecting within a designated band. * The units of measurement is given by {@link #getUnits()}. * - * @return Longest wavelength that the sensor is capable of collecting within a designated band, + * @return longest wavelength that the sensor is capable of collecting within a designated band, * or {@code null} if unspecified. * * @since 0.5 @@ -231,7 +232,7 @@ public class DefaultBand extends Default /** * Sets the longest wavelength that the sensor is capable of collecting within a designated band. * - * @param newValue The new longest wavelength, or {@code null}. + * @param newValue the new longest wavelength, or {@code null}. * @throws IllegalArgumentException if the given value is negative. * * @since 0.5 @@ -246,7 +247,7 @@ public class DefaultBand extends Default /** * Returns units in which sensor wavelengths are expressed. * - * @return Units in which sensor wavelengths are expressed. + * @return units in which sensor wavelengths are expressed. * * @since 0.5 * @@ -273,7 +274,7 @@ public class DefaultBand extends Default /** * Returns the designation of criterion for defining maximum and minimum wavelengths for a spectral band. * - * @return Criterion for defining maximum and minimum wavelengths, or {@code null}. + * @return criterion for defining maximum and minimum wavelengths, or {@code null}. */ @Override @XmlElement(name = "bandBoundaryDefinition", namespace = Namespaces.GMI) @@ -284,7 +285,7 @@ public class DefaultBand extends Default /** * Sets designation of criterion for defining maximum and minimum wavelengths for a spectral band. * - * @param newValue The new band definition. + * @param newValue the new band definition. */ public void setBandBoundaryDefinition(final BandDefinition newValue) { checkWritePermission(); @@ -328,7 +329,7 @@ public class DefaultBand extends Default * Returns the wavelength at which the response is the highest. * The units of measurement is given by {@link #getBoundUnits()}. * - * @return Wavelength at which the response is the highest, or {@code null} if unspecified. + * @return wavelength at which the response is the highest, or {@code null} if unspecified. */ @Override @ValueRange(minimum = 0) @@ -340,7 +341,7 @@ public class DefaultBand extends Default /** * Sets the wavelength at which the response is the highest. * - * @param newValue The new peak response, or {@code null}. + * @param newValue the new peak response, or {@code null}. * @throws IllegalArgumentException if the given value is negative. */ public void setPeakResponse(final Double newValue) { @@ -371,7 +372,7 @@ public class DefaultBand extends Default /** * Returns the number of discrete numerical values in the grid data. * - * @return Number of discrete numerical values in the grid data, or {@code null} if none. + * @return number of discrete numerical values in the grid data, or {@code null} if none. */ @Override @ValueRange(minimum = 0) @@ -383,7 +384,7 @@ public class DefaultBand extends Default /** * Sets the number of discrete numerical values in the grid data. * - * @param newValue The new tone gradation. + * @param newValue the new tone gradation. */ public void setToneGradation(final Integer newValue) { checkWritePermission(); @@ -464,7 +465,7 @@ public class DefaultBand extends Default /** * Returns the polarization of the radiation transmitted. * - * @return Polarization of the radiation transmitted, or {@code null}. + * @return polarization of the radiation transmitted, or {@code null}. */ @Override @XmlElement(name = "transmittedPolarization", namespace = Namespaces.GMI) @@ -475,7 +476,7 @@ public class DefaultBand extends Default /** * Sets the polarization of the radiation transmitted. * - * @param newValue The new transmitted polarization. + * @param newValue the new transmitted polarization. */ public void setTransmittedPolarization(final PolarizationOrientation newValue) { checkWritePermission(); @@ -485,7 +486,7 @@ public class DefaultBand extends Default /** * Returns polarization of the radiation detected. * - * @return Polarization of the radiation detected, or {@code null}. + * @return polarization of the radiation detected, or {@code null}. */ @Override @XmlElement(name = "detectedPolarization", namespace = Namespaces.GMI) @@ -496,7 +497,7 @@ public class DefaultBand extends Default /** * Sets the polarization of the radiation detected. * - * @param newValue The new detected polarization. + * @param newValue the new detected polarization. */ public void setDetectedPolarization(final PolarizationOrientation newValue) { checkWritePermission(); Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultCoverageDescription.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultCoverageDescription.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultCoverageDescription.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultCoverageDescription.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -55,6 +55,7 @@ import static org.opengis.annotation.Spe * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_CoverageDescription_Type", propOrder = { "attributeDescription", "contentType", Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultFeatureCatalogueDescription.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultFeatureCatalogueDescription.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultFeatureCatalogueDescription.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultFeatureCatalogueDescription.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -50,6 +50,7 @@ import static org.opengis.annotation.Spe * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_FeatureCatalogueDescription_Type", propOrder = { "compliant", "languages", Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultFeatureTypeInfo.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultFeatureTypeInfo.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultFeatureTypeInfo.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultFeatureTypeInfo.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -61,6 +61,7 @@ import static org.opengis.annotation.Spe * @see org.apache.sis.storage.FeatureNaming * @see org.apache.sis.feature.DefaultFeatureType */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_FeatureTypeInfo", propOrder = { "featureTypeName", "featureInstanceCount" Modified: sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultImageDescription.java URL: http://svn.apache.org/viewvc/sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultImageDescription.java?rev=1779559&r1=1779558&r2=1779559&view=diff ============================================================================== --- sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultImageDescription.java [UTF-8] (original) +++ sis/trunk/core/sis-metadata/src/main/java/org/apache/sis/metadata/iso/content/DefaultImageDescription.java [UTF-8] Fri Jan 20 04:34:26 2017 @@ -48,6 +48,7 @@ import static org.apache.sis.internal.me * @version 0.5 * @module */ +@SuppressWarnings("CloneableClassWithoutClone") // ModifiableMetadata needs shallow clones. @XmlType(name = "MD_ImageDescription_Type", propOrder = { "illuminationElevationAngle", "illuminationAzimuthAngle",
