This is an automated email from the ASF dual-hosted git repository.
desruisseaux pushed a commit to branch geoapi-4.0
in repository https://gitbox.apache.org/repos/asf/sis.git
commit 93f2b97ca32434c58084e62eeb32bbb898ffac36
Author: Martin Desruisseaux <martin.desruisse...@geomatys.com>
AuthorDate: Sat May 18 14:41:15 2024 +0200
Change the parameter name of central meridian in Robinson and Sinusoidal
projections.
---
.../apache/sis/referencing/operation/provider/Robinson.java | 12 +++++++++++-
.../sis/referencing/operation/provider/Sinusoidal.java | 13 +++++++++++--
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git
a/endorsed/src/org.apache.sis.referencing/main/org/apache/sis/referencing/operation/provider/Robinson.java
b/endorsed/src/org.apache.sis.referencing/main/org/apache/sis/referencing/operation/provider/Robinson.java
index 94c694f99d..8294c53eea 100644
---
a/endorsed/src/org.apache.sis.referencing/main/org/apache/sis/referencing/operation/provider/Robinson.java
+++
b/endorsed/src/org.apache.sis.referencing/main/org/apache/sis/referencing/operation/provider/Robinson.java
@@ -27,6 +27,16 @@ import
org.apache.sis.referencing.operation.projection.NormalizedProjection;
/**
* The provider for <q>Robinson</q> projection.
+ * This projection method has no associated EPSG code.
+ *
+ * <h2>Departure in parameter name compared to GDAL</h2>
+ * As of May 2024, the {@link #CENTRAL_MERIDIAN} parameter name declared on
the GDAL web site
+ * is <q>Longitude of projection center</q> for EPSG and
<q>longitude_of_center</q> for OGC.
+ * However, EPSG does not define this projection, and OGC names generally
follow ESRI names.
+ * The parameter name declared by ESRI for projection ESRI:54030 is
<q>Central_Meridian</q>.
+ * This class follows ESRI name for OGC and uses <q>Longitude of natural
origin</q> for EPSG.
+ * The latter is the name that we found in usage for WKT 2 strings, is used by
PROJ implementation
+ * and seems to be match better the usages in the EPSG geodetic dataset.
*
* @author Martin Desruisseaux (Geomatys)
*
@@ -50,7 +60,7 @@ public final class Robinson extends MapProjection {
* <tr><td> OGC: </td><td> central_meridian </td></tr>
* <tr><td> GeoTIFF: </td><td> CenterLong </td></tr>
* <tr><td> Proj4: </td><td> lon_0 </td></tr>
- * <tr><td> EPSG: </td><td> Longitude of projection centre </td></tr>
+ * <tr><td> EPSG: </td><td> Longitude of natural origin </td></tr>
* </table>
*/
public static final ParameterDescriptor<Double> CENTRAL_MERIDIAN =
Sinusoidal.CENTRAL_MERIDIAN;
diff --git
a/endorsed/src/org.apache.sis.referencing/main/org/apache/sis/referencing/operation/provider/Sinusoidal.java
b/endorsed/src/org.apache.sis.referencing/main/org/apache/sis/referencing/operation/provider/Sinusoidal.java
index 782cdf4be7..a952fb2812 100644
---
a/endorsed/src/org.apache.sis.referencing/main/org/apache/sis/referencing/operation/provider/Sinusoidal.java
+++
b/endorsed/src/org.apache.sis.referencing/main/org/apache/sis/referencing/operation/provider/Sinusoidal.java
@@ -30,6 +30,15 @@ import
org.apache.sis.referencing.operation.projection.NormalizedProjection;
* This is a pseudo-cylindrical (or "false cylindrical") projection.
* This projection method has no associated EPSG code.
*
+ * <h2>Departure in parameter name compared to GDAL</h2>
+ * As of May 2024, the {@link #CENTRAL_MERIDIAN} parameter name declared on
the GDAL web site
+ * is <q>Longitude of projection center</q> for EPSG and
<q>longitude_of_center</q> for OGC.
+ * However, EPSG does not define this projection, and OGC names generally
follow ESRI names.
+ * The parameter name declared by ESRI for projection ESRI:54030 is
<q>Central_Meridian</q>.
+ * This class follows ESRI name for OGC and uses <q>Longitude of natural
origin</q> for EPSG.
+ * The latter is the name that we found in usage for WKT 2 strings, is used by
PROJ implementation
+ * and seems to be match better the usages in the EPSG geodetic dataset.
+ *
* @author Martin Desruisseaux (Geomatys)
*
* @see <a
href="https://en.wikipedia.org/wiki/Sinusoidal_projection";>Sinusoidal
projection on Wikipedia</a>
@@ -53,7 +62,7 @@ public class Sinusoidal extends MapProjection {
* <tr><td> OGC: </td><td> central_meridian </td></tr>
* <tr><td> GeoTIFF: </td><td> CenterLong </td></tr>
* <tr><td> Proj4: </td><td> lon_0 </td></tr>
- * <tr><td> EPSG: </td><td> Longitude of projection centre </td></tr>
+ * <tr><td> EPSG: </td><td> Longitude of natural origin </td></tr>
* </table>
*/
public static final ParameterDescriptor<Double> CENTRAL_MERIDIAN;
@@ -95,7 +104,7 @@ public class Sinusoidal extends MapProjection {
static {
final var builder = new ParameterBuilder().setRequired(true);
CENTRAL_MERIDIAN =
createLongitude(builder.addNamesAndIdentifiers(ESRI.CENTRAL_MERIDIAN)
- .addName(ObliqueMercator.LONGITUDE_OF_CENTRE.getName()));
+ .addName(Equirectangular.LONGITUDE_OF_ORIGIN.getName()));
PARAMETERS = builder
.addName ("Sinusoidal")
