This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch fix/bugs in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-ui.git
commit e2d3fc8817c37cb82cdcf557c3530d143e01d3a5 Author: gaohongtao <[email protected]> AuthorDate: Sun Mar 4 20:39:29 2018 +0800 Fix trace tag isError display issue --- mock/service.js | 2 +- mock/trace.js | 7 +++++++ src/components/TraceStack/index.js | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/mock/service.js b/mock/service.js index 7876ad7..1d3ba58 100644 --- a/mock/service.js +++ b/mock/service.js @@ -69,7 +69,7 @@ export default { target: 1, 'isAlert|1': true, 'callType|1': ['rpc', 'http', 'dubbo'], - 'callsPerSec|0-1': 1, + 'callsPerSec|0-100': 1, 'avgResponseTime|500-5000': 1, }))).concat(downNodes.nodes.map(node => (mockjs.mock({ source: 1, diff --git a/mock/trace.js b/mock/trace.js index c1167c5..2881e9c 100644 --- a/mock/trace.js +++ b/mock/trace.js @@ -46,6 +46,7 @@ export default { peer: '@ip', 'tags|1-5': [{ key: 'db.type', value: 'aa' }], 'logs|2-10': [{ 'time|+1': 1516151345000, 'data|3-8': [{ key: 'db.type', value: 'aa' }] }], + 'isError|1': true, }, { spanId: 2, @@ -59,6 +60,7 @@ export default { 'component|1': ['MySQL', 'H2', 'Spring'], peer: '@ip', 'tags|1-5': [{ key: 'db.type', value: 'aa' }], + 'isError|1': true, }, { spanId: 3, @@ -72,6 +74,7 @@ export default { 'component|1': ['MySQL', 'H2', 'Spring'], peer: '@ip', 'tags|1-5': [{ key: 'db.type', value: 'aa' }], + 'isError|1': true, }, { spanId: 4, @@ -85,6 +88,7 @@ export default { 'component|1': ['MySQL', 'H2', 'Spring'], peer: '@ip', 'tags|1-5': [{ key: 'db.type', value: 'aa' }], + 'isError|1': true, }, { spanId: 5, @@ -98,6 +102,7 @@ export default { 'component|1': ['RockerMQ'], peer: '@ip', 'tags|1-5': [{ key: 'producer', value: 'tt' }], + 'isError|1': true, }, { spanId: 6, @@ -116,6 +121,7 @@ export default { parentSegmentId: 1, }, ], + 'isError|1': true, }, { spanId: 6, @@ -138,6 +144,7 @@ export default { type: 'CROSS_THREAD', }, ], + 'isError|1': true, }, ], }, diff --git a/src/components/TraceStack/index.js b/src/components/TraceStack/index.js index 1023109..677f643 100644 --- a/src/components/TraceStack/index.js +++ b/src/components/TraceStack/index.js @@ -255,7 +255,7 @@ class TraceStack extends PureComponent { }, { title: 'is error', - content: span.isError, + content: `${span.isError}`, }, ]; data = base.concat(span.tags.map(t => ({ title: t.key, content: t.value }))); -- To stop receiving notification emails like this one, please contact [email protected].
