This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 4d7192f  fix grpc issue (#1039)
4d7192f is described below

commit 4d7192f64c394901d97959bffac25c22dd19ed74
Author: Xin,Zhang <zhang...@apache.org>
AuthorDate: Fri Apr 6 22:44:47 2018 +0800

    fix grpc issue (#1039)
---
 .../skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java
 
b/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java
index ce74a8f..aa713e3 100644
--- 
a/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java
+++ 
b/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java
@@ -75,7 +75,7 @@ public class BlockingCallClientInterceptor extends 
ForwardingClientCall.SimpleFo
 
         @Override public void onClose(Status status, Metadata trailers) {
             delegate().onClose(status, trailers);
-            if (status.isOk()) {
+            if (!status.isOk()) {
                 AbstractSpan activeSpan = ContextManager.activeSpan();
                 activeSpan.errorOccurred().log(status.getCause());
                 Tags.STATUS_CODE.set(activeSpan, status.getCode().name());

-- 
To stop receiving notification emails like this one, please contact
wush...@apache.org.

Reply via email to