wu-sheng commented on code in PR #126:
URL: https://github.com/apache/skywalking-helm/pull/126#discussion_r1325259126
##########
chart/skywalking/Chart.yaml:
##########
@@ -38,3 +38,7 @@ dependencies:
version: 12.1.2
repository:
https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
condition: postgresql.enabled
+ - name: skywalking-banyandb-helm
+ version: 0.0.0-67df1c7
+ repository: oci://ghcr.io/apache/skywalking-banyandb-helm
Review Comment:
> Because we deploy skywalking chart snapshot to ghcr so this makes sense in
main branch but have to remember to change to a released one for banyandb chart
before releasing. This also implies that a skywalking chart release depends on
a banyandb release.
For me, the concern is, that we don't release `helm` repo in high frequency,
so, most likely we definitely will lose track and release the next helm with
this snapshot repository.
This PR is never urgent, so, if you feel the BanyanDB helm repo is ready to
release, please go ahead to do so. I believe no matter banyandb helm repo is
relying on BanyanDB server 0.5 release or not, it is close to be ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
