kezhenxu94 commented on code in PR #31: URL: https://github.com/apache/skywalking-terraform/pull/31#discussion_r1376104688
########## ansible/roles/install-java/tasks/main.yml: ########## @@ -15,19 +15,19 @@ --- - name: Install Java 11 on RHEL-based systems - package: + ansible.builtin.package: Review Comment: > Let's not use the `ansible.builtin.`. I know this is being explicit instead of implicit. However, this is inconsistent with all our other playbooks. Also, this has no impact on the functioning of our playbooks. Let me know of you think otherwise. Thanks for the comment, the purpose of this pull request is to unify all the module names by using full-qualified names, and should be fixed in all playbooks in this repo, so if there is anything missing then I shall fix them all in this PR. The main purpose is to add a linter to remind simple errors that might be introduced, and the default rules of the linter complains the builtin modules should be explicitly prefixed with `ansible.builtin.`, do you prefer we skip this rule? I can add the rule to the skip list so we don't report this kind of errors in the linter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
