ButterBright commented on code in PR #145:
URL: https://github.com/apache/skywalking-helm/pull/145#discussion_r1542254539
##########
chart/skywalking/Chart.yaml:
##########
@@ -39,6 +39,7 @@ dependencies:
repository:
https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
condition: postgresql.enabled
- name: skywalking-banyandb-helm
- version: 0.1.0
- repository: oci://registry-1.docker.io/apache
+ alias: banyandb
+ version: 0.0.0-8bdff75
+ repository: oci://ghcr.io/apache/skywalking-banyandb-helm
Review Comment:
> @hanahmily told me, your deployment should not care about BanyanDB 0.5 or
0.6(dev or unreleased). So, this should not be a blocker for you. I know 0.6 is
much better, so you only need to keep all in 0.5 by default, and upgrade to 0.6
once it is released.
There is a [feature](https://github.com/apache/skywalking-banyandb/pull/331)
related to etcd authentication that has not been implemented in version 0.5. It
seems that we still need to rely on the upcoming BanyanDB 0.6 version. After
discussing with @hanahmily , we decide to change these tags later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
