kezhenxu94 commented on code in PR #156:
URL: https://github.com/apache/skywalking-helm/pull/156#discussion_r1689048406
##########
chart/operator/templates/rbac.yaml:
##########
@@ -473,7 +473,7 @@ subjects:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
- name: {{ include "operator.fullname" . | trunc (int (sub 63 (len
"-manager-role"))) | printf "%s-manager-role" }} binding
+ name: {{ include "operator.fullname" . | trunc (int (sub 63 (len
"-manager-role"))) | printf "%s-manager-role" }}binding
Review Comment:
Let's add a dash here
```suggestion
name: {{ include "operator.fullname" . | trunc (int (sub 63 (len
"-manager-role"))) | printf "%s-manager-role" }}-binding
```
##########
chart/operator/templates/rbac.yaml:
##########
@@ -459,7 +459,7 @@ rules:
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
- name: {{ include "operator.fullname" . | trunc (int (sub 63 (len
"-leader-election-role"))) | printf "%s-leader-election-role" }} binding
+ name: {{ include "operator.fullname" . | trunc (int (sub 63 (len
"-leader-election-role"))) | printf "%s-leader-election-role" }}binding
Review Comment:
```suggestion
name: {{ include "operator.fullname" . | trunc (int (sub 63 (len
"-leader-election-role"))) | printf "%s-leader-election-role" }}-binding
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
