This is an automated email from the ASF dual-hosted git repository.
liuhan pushed a commit to branch missing-details
in repository https://gitbox.apache.org/repos/asf/skywalking-rover.git
The following commit(s) were added to refs/heads/missing-details by this push:
new 45a8e4a test log
45a8e4a is described below
commit 45a8e4a7624d791a71a7ae4f373da2923fae3f25
Author: mrproliu <[email protected]>
AuthorDate: Fri Dec 13 07:32:51 2024 +0800
test log
---
pkg/accesslog/collector/protocols/http1.go | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/pkg/accesslog/collector/protocols/http1.go
b/pkg/accesslog/collector/protocols/http1.go
index 3e424fd..70ea60d 100644
--- a/pkg/accesslog/collector/protocols/http1.go
+++ b/pkg/accesslog/collector/protocols/http1.go
@@ -88,9 +88,9 @@ func (p *HTTP1Protocol) Analyze(connection
*PartitionConnection, _ *AnalyzeHelpe
return nil
}
- messageType, err := reader.IdentityMessageType(buf)
headerTmp := make([]byte, 16)
buf.Peek(headerTmp)
+ messageType, err := reader.IdentityMessageType(buf)
log.Infof("ready to reading message type, messageType: %v, buf:
%p, data id: %d, "+
"connection ID: %d, random ID: %d, error: %v, header:
%s", messageType, buf, buf.Position().DataID(),
metrics.ConnectionID, metrics.RandomID, err,
string(headerTmp))
@@ -105,12 +105,16 @@ func (p *HTTP1Protocol) Analyze(connection
*PartitionConnection, _ *AnalyzeHelpe
var result enums.ParseResult
switch messageType {
case reader.MessageTypeRequest:
- result, _ = p.handleRequest(metrics, buf)
+ result, err = p.handleRequest(metrics, buf)
case reader.MessageTypeResponse:
- result, _ = p.handleResponse(metrics, buf)
+ result, err = p.handleResponse(metrics, buf)
case reader.MessageTypeUnknown:
result = enums.ParseResultSkipPackage
}
+ if err != nil {
+ http1Log.Warnf("failed to handle HTTP/1.x protocol,
connection ID: %d, random ID: %d, data id: %d, error: %v",
+ metrics.ConnectionID, metrics.RandomID,
buf.Position().DataID(), err)
+ }
finishReading := false
switch result {
