This is an automated email from the ASF dual-hosted git repository.
liuhan pushed a commit to branch reduce-handle-connect-time
in repository https://gitbox.apache.org/repos/asf/skywalking-rover.git
The following commit(s) were added to refs/heads/reduce-handle-connect-time by
this push:
new 716ba4b update as ref
716ba4b is described below
commit 716ba4b440aa278877330ba15d8a792b63ed7b34
Author: mrproliu <[email protected]>
AuthorDate: Sun Dec 29 22:27:36 2024 +0800
update as ref
---
pkg/accesslog/collector/protocols/queue.go | 2 +-
pkg/accesslog/events/data.go | 4 ++--
pkg/profiling/task/network/analyze/events/data.go | 4 ++--
pkg/profiling/task/network/analyze/layer7/events.go | 2 +-
pkg/tools/buffer/buffer.go | 8 ++++----
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/pkg/accesslog/collector/protocols/queue.go
b/pkg/accesslog/collector/protocols/queue.go
index 61e0c60..b336f9d 100644
--- a/pkg/accesslog/collector/protocols/queue.go
+++ b/pkg/accesslog/collector/protocols/queue.go
@@ -102,7 +102,7 @@ func (q *AnalyzeQueue) Start(ctx context.Context) {
})
q.eventQueue.RegisterReceiver(q.context.BPF.SocketDataUploadQueue,
int(q.perCPUBuffer),
q.context.Config.ProtocolAnalyze.ParseParallels, func()
interface{} {
- return &events.SocketDataUploadEvent{Buffer:
buffer.BorrowNewBuffer()}
+ return &events.SocketDataUploadEvent{Buffer:
*buffer.BorrowNewBuffer()}
}, func(data interface{}) int {
return
int(data.(*events.SocketDataUploadEvent).ConnectionID)
})
diff --git a/pkg/accesslog/events/data.go b/pkg/accesslog/events/data.go
index 2390a2a..d3828c9 100644
--- a/pkg/accesslog/events/data.go
+++ b/pkg/accesslog/events/data.go
@@ -41,8 +41,8 @@ type SocketDataUploadEvent struct {
Buffer [2048]byte
}
-func (s *SocketDataUploadEvent) ReleaseBuffer() [2048]byte {
- return s.Buffer
+func (s *SocketDataUploadEvent) ReleaseBuffer() *[2048]byte {
+ return &s.Buffer
}
func (s *SocketDataUploadEvent) ReadFrom(r *reader.Reader) {
diff --git a/pkg/profiling/task/network/analyze/events/data.go
b/pkg/profiling/task/network/analyze/events/data.go
index 53f388f..3c59378 100644
--- a/pkg/profiling/task/network/analyze/events/data.go
+++ b/pkg/profiling/task/network/analyze/events/data.go
@@ -40,8 +40,8 @@ type SocketDataUploadEvent struct {
Buffer [2048]byte
}
-func (s *SocketDataUploadEvent) ReleaseBuffer() [2048]byte {
- return s.Buffer
+func (s *SocketDataUploadEvent) ReleaseBuffer() *[2048]byte {
+ return &s.Buffer
}
func (s *SocketDataUploadEvent) Protocol() enums.ConnectionProtocol {
diff --git a/pkg/profiling/task/network/analyze/layer7/events.go
b/pkg/profiling/task/network/analyze/layer7/events.go
index 73c3fdf..1844430 100644
--- a/pkg/profiling/task/network/analyze/layer7/events.go
+++ b/pkg/profiling/task/network/analyze/layer7/events.go
@@ -38,7 +38,7 @@ func (l *Listener) initSocketDataQueue(parallels, queueSize
int, config *profili
func (l *Listener) startSocketData(ctx context.Context, bpfLoader *bpf.Loader)
{
// socket buffer data
l.socketDataQueue.RegisterReceiver(bpfLoader.SocketDataUploadQueue,
l.protocolPerCPUBuffer, 1, func() interface{} {
- return &analyzeBase.SocketDataUploadEvent{Buffer:
buffer.BorrowNewBuffer()}
+ return &analyzeBase.SocketDataUploadEvent{Buffer:
*buffer.BorrowNewBuffer()}
}, func(data interface{}) int {
return
int(data.(*analyzeBase.SocketDataUploadEvent).ConnectionID)
})
diff --git a/pkg/tools/buffer/buffer.go b/pkg/tools/buffer/buffer.go
index 86ad364..7054420 100644
--- a/pkg/tools/buffer/buffer.go
+++ b/pkg/tools/buffer/buffer.go
@@ -40,13 +40,13 @@ var (
PooledBuffer = sync.Pool{
New: func() any {
- return [2048]byte{}
+ return &[2048]byte{}
},
}
)
-func BorrowNewBuffer() [2048]byte {
- return PooledBuffer.Get().([2048]byte)
+func BorrowNewBuffer() *[2048]byte {
+ return PooledBuffer.Get().(*[2048]byte)
}
type SocketDataBuffer interface {
@@ -82,7 +82,7 @@ type SocketDataBuffer interface {
// EndTime the data end timestamp
EndTime() uint64
- ReleaseBuffer() [2048]byte
+ ReleaseBuffer() *[2048]byte
}
type SocketDataDetail interface {
