SLIDER-799 quick code review of this while looking @ log aggregation setup
Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/9e671614 Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/9e671614 Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/9e671614 Branch: refs/heads/feature/SLIDER-799-AM-managed-relax Commit: 9e671614f24570ecfedb50a5eaf52e52e74825b4 Parents: 06ac342 Author: Steve Loughran <[email protected]> Authored: Wed Mar 18 10:52:21 2015 +0000 Committer: Steve Loughran <[email protected]> Committed: Wed Mar 18 10:52:21 2015 +0000 ---------------------------------------------------------------------- .../java/org/apache/slider/core/main/ServiceShutdownHook.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/9e671614/slider-core/src/main/java/org/apache/slider/core/main/ServiceShutdownHook.java ---------------------------------------------------------------------- diff --git a/slider-core/src/main/java/org/apache/slider/core/main/ServiceShutdownHook.java b/slider-core/src/main/java/org/apache/slider/core/main/ServiceShutdownHook.java index 83448ad..de55789 100644 --- a/slider-core/src/main/java/org/apache/slider/core/main/ServiceShutdownHook.java +++ b/slider-core/src/main/java/org/apache/slider/core/main/ServiceShutdownHook.java @@ -40,7 +40,7 @@ public class ServiceShutdownHook implements Runnable { private Runnable hook; public ServiceShutdownHook(Service service) { - serviceRef = new WeakReference<Service>(service); + serviceRef = new WeakReference<>(service); } public void register(int priority) { @@ -74,7 +74,7 @@ public class ServiceShutdownHook implements Runnable { // Stop the Service service.stop(); } catch (Throwable t) { - LOG.info("Error stopping {}: {}", service.getName(), t); + LOG.info("Error stopping {}", service.getName(), t); } } }
