SLIDER-1030 "slider nodes" command failing if you list a cluster
Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/0a9b3068 Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/0a9b3068 Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/0a9b3068 Branch: refs/heads/develop Commit: 0a9b306815e9084d4e0f0da81b2f5930dd0b32f2 Parents: 2d0be8f Author: Steve Loughran <ste...@apache.org> Authored: Thu Dec 17 11:00:18 2015 +0000 Committer: Steve Loughran <ste...@apache.org> Committed: Thu Dec 17 11:00:18 2015 +0000 ---------------------------------------------------------------------- .../org/apache/slider/common/params/ActionNodesArgs.java | 5 +++++ .../org/apache/slider/funtest/lifecycle/AASleepIT.groovy | 10 +++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/0a9b3068/slider-core/src/main/java/org/apache/slider/common/params/ActionNodesArgs.java ---------------------------------------------------------------------- diff --git a/slider-core/src/main/java/org/apache/slider/common/params/ActionNodesArgs.java b/slider-core/src/main/java/org/apache/slider/common/params/ActionNodesArgs.java index 5ddccf6..ec38c80 100644 --- a/slider-core/src/main/java/org/apache/slider/common/params/ActionNodesArgs.java +++ b/slider-core/src/main/java/org/apache/slider/common/params/ActionNodesArgs.java @@ -53,6 +53,11 @@ public class ActionNodesArgs extends AbstractActionArgs { } @Override + public int getMaxParams() { + return 1; + } + + @Override public String toString() { final StringBuilder sb = new StringBuilder( "ActionNodesArgs{"); http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/0a9b3068/slider-funtest/src/test/groovy/org/apache/slider/funtest/lifecycle/AASleepIT.groovy ---------------------------------------------------------------------- diff --git a/slider-funtest/src/test/groovy/org/apache/slider/funtest/lifecycle/AASleepIT.groovy b/slider-funtest/src/test/groovy/org/apache/slider/funtest/lifecycle/AASleepIT.groovy index c42edf8..faf9a25 100644 --- a/slider-funtest/src/test/groovy/org/apache/slider/funtest/lifecycle/AASleepIT.groovy +++ b/slider-funtest/src/test/groovy/org/apache/slider/funtest/lifecycle/AASleepIT.groovy @@ -75,10 +75,18 @@ public class AASleepIT extends AgentCommandTestBase describe "list nodes" def healthyNodes = listNodes("", true) + def allNodes = listNodes("", false) def healthyNodeCount = healthyNodes.size() + def allNodeCount = allNodes.size(); + def unhealthyNodeCount = allNodeCount - healthyNodeCount describe("Cluster nodes : ${healthyNodeCount}") - log.info(NodeInformationList.createSerializer().toJson(healthyNodes)) + def nodesPrettyJson = NodeInformationList.createSerializer().toJson(allNodes) + log.info(nodesPrettyJson) + if (unhealthyNodeCount > 0 ) { + log.warn("$unhealthyNodeCount unhealthy nodes") + } + assert healthyNodeCount > 0 File launchReportFile = createTempJsonFile();
