Repository: incubator-slider
Updated Branches:
  refs/heads/develop dfa83c8ca -> 62ef3cdf9


SLIDER-1242 Review uses of double-checked locking


Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/62ef3cdf
Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/62ef3cdf
Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/62ef3cdf

Branch: refs/heads/develop
Commit: 62ef3cdf94ba016d064d39a1a8ce7b6db99ee22a
Parents: dfa83c8
Author: Billie Rinaldi <bil...@apache.org>
Authored: Tue Sep 5 13:28:58 2017 -0700
Committer: Billie Rinaldi <bil...@apache.org>
Committed: Tue Sep 5 13:28:58 2017 -0700

----------------------------------------------------------------------
 .../org/apache/slider/providers/agent/AgentProviderService.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/62ef3cdf/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
----------------------------------------------------------------------
diff --git 
a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
 
b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
index 59b200d..89b3b3c 100644
--- 
a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
+++ 
b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
@@ -2009,7 +2009,7 @@ public class AgentProviderService extends 
AbstractProviderService implements
   }
 
   protected Map<String, List<ExportEntry>> getCurrentExports(String groupName) 
{
-    if (!this.exportGroups.containsKey(groupName)) {
+    if (this.exportGroups.get(groupName) == null) {
       synchronized (this.exportGroups) {
         if (!this.exportGroups.containsKey(groupName)) {
           this.exportGroups.put(groupName, new ConcurrentHashMap<String, 
List<ExportEntry>>());
@@ -3104,7 +3104,7 @@ public class AgentProviderService extends 
AbstractProviderService implements
   }
 
   protected Map<String, String> getAllocatedPorts(String containerId) {
-    if (!this.allocatedPorts.containsKey(containerId)) {
+    if (this.allocatedPorts.get(containerId) == null) {
       synchronized (this.allocatedPorts) {
         if (!this.allocatedPorts.containsKey(containerId)) {
           this.allocatedPorts.put(containerId,

Reply via email to