Author: cziegeler
Date: Mon Dec 16 01:29:13 2013
New Revision: 1551102
URL: http://svn.apache.org/r1551102
Log:
Minor code optimizations
Modified:
sling/trunk/bundles/resourceaccesssecurity/src/main/java/org/apache/sling/resourceaccesssecurity/impl/ResourceAccessSecurityImpl.java
Modified:
sling/trunk/bundles/resourceaccesssecurity/src/main/java/org/apache/sling/resourceaccesssecurity/impl/ResourceAccessSecurityImpl.java
URL:
http://svn.apache.org/viewvc/sling/trunk/bundles/resourceaccesssecurity/src/main/java/org/apache/sling/resourceaccesssecurity/impl/ResourceAccessSecurityImpl.java?rev=1551102&r1=1551101&r2=1551102&view=diff
==============================================================================
---
sling/trunk/bundles/resourceaccesssecurity/src/main/java/org/apache/sling/resourceaccesssecurity/impl/ResourceAccessSecurityImpl.java
(original)
+++
sling/trunk/bundles/resourceaccesssecurity/src/main/java/org/apache/sling/resourceaccesssecurity/impl/ResourceAccessSecurityImpl.java
Mon Dec 16 01:29:13 2013
@@ -63,19 +63,18 @@ public class ResourceAccessSecurityImpl
}
private List<ResourceAccessGateHandler>
getMatchingResourceAccessGateHandlers(
- String path, ResourceAccessGate.Operation operation) {
+ final String path, final ResourceAccessGate.Operation operation) {
//
// TODO: maybe caching some frequent paths with read operation would be
// a good idea
//
- List<ResourceAccessGateHandler> returnValue = resourceAccessGateTracker
- .getResourceAccessGateHandlers();
+ final List<ResourceAccessGateHandler> handlers =
resourceAccessGateTracker.getResourceAccessGateHandlers();
+ List<ResourceAccessGateHandler> returnValue = handlers;
- if (returnValue.size() > 0) {
+ if (handlers.size() > 0) {
returnValue = new ArrayList<ResourceAccessGateHandler>();
- for (ResourceAccessGateHandler resourceAccessGateHandler :
resourceAccessGateTracker
- .getResourceAccessGateHandlers()) {
+ for (ResourceAccessGateHandler resourceAccessGateHandler :
handlers) {
if (resourceAccessGateHandler.matches(path, operation)) {
returnValue.add(resourceAccessGateHandler);
}
@@ -85,15 +84,10 @@ public class ResourceAccessSecurityImpl
return returnValue;
}
- public boolean areResourceAccessGatesRegistered() {
- return (resourceAccessGateTracker.size() > 0);
- }
-
@Override
- public Resource getReadableResource(Resource resource) {
+ public Resource getReadableResource(final Resource resource) {
Resource returnValue = resource;
ResourceResolver resResolver = resource.getResourceResolver();
- String user = resResolver.getUserID();
List<ResourceAccessGateHandler> accessGateHandlers =
getMatchingResourceAccessGateHandlers(
resource.getPath(), ResourceAccessGate.Operation.READ);