danilobanjac commented on code in PR #138:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/138#discussion_r1567399946
##########
src/main/java/org/apache/sling/distribution/journal/bookkeeper/SubscriberMetrics.java:
##########
@@ -112,7 +105,7 @@ public SubscriberMetrics(@Reference MetricsService
metricsService) {
* @return a Sling Metrics histogram
*/
public Histogram getImportedPackageSize() {
- return importedPackageSize;
+ return metricsService.histogram(getMetricName(IMPORTED_PACKAGE_SIZE,
tags));
Review Comment:
Only one question, you've moved metrics initialisation to their
corresponding getter methods. That means that we would execute the whole thing
each time a getter is called, does this have any performance implications?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
