svn commit: r1597071 - /sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingBundleModuleFactory.java

[rombert]

Author: rombert
Date: Fri May 23 12:07:35 2014
New Revision: 1597071

URL: http://svn.apache.org/r1597071
Log:
Minor cleanups in SlingBundleModuleFactory

Modified:
    
sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingBundleModuleFactory.java

Modified: 
sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingBundleModuleFactory.java
URL: 
http://svn.apache.org/viewvc/sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingBundleModuleFactory.java?rev=1597071&r1=1597070&r2=1597071&view=diff
==============================================================================
--- 
sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingBundleModuleFactory.java
 (original)
+++ 
sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingBundleModuleFactory.java
 Fri May 23 12:07:35 2014
@@ -78,7 +78,7 @@ public class SlingBundleModuleFactory ex
                 }
             }
         } catch (CoreException ce) {
-            // TODO logging
+            Activator.getDefault().getPluginLogger().warn("Failed creating 
module for project " + project, ce);
         }
 
         return null;
@@ -86,6 +86,8 @@ public class SlingBundleModuleFactory ex
 
     static class SlingBundleModuleDelegate extends ProjectModule {
 
+        private static final IModule[] EMPTY_MODULES = new IModule[0];
+
         public SlingBundleModuleDelegate(IModule module) {
             super(module.getProject());
         }
@@ -171,7 +173,7 @@ public class SlingBundleModuleFactory ex
 
         @Override
         public IModule[] getChildModules() {
-            return new IModule[0]; // TODO revisit, do we need child modules?
+            return EMPTY_MODULES;
         }
     }
 }