This is an automated email from the ASF dual-hosted git repository.

sseifert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-launchpad-comparator.git


The following commit(s) were added to refs/heads/master by this push:
     new 6c09bca  close git repository after usage
6c09bca is described below

commit 6c09bcad7515e141df34c7d2ed94358f897085c6
Author: Stefan Seifert <[email protected]>
AuthorDate: Thu Dec 19 10:55:11 2024 +0100

    close git repository after usage
---
 .../sling/tooling/lc/git/GitChangeLogFinder.java   | 28 +++++++++++-----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git 
a/src/main/java/org/apache/sling/tooling/lc/git/GitChangeLogFinder.java 
b/src/main/java/org/apache/sling/tooling/lc/git/GitChangeLogFinder.java
index a94eb71..4e25b08 100644
--- a/src/main/java/org/apache/sling/tooling/lc/git/GitChangeLogFinder.java
+++ b/src/main/java/org/apache/sling/tooling/lc/git/GitChangeLogFinder.java
@@ -54,28 +54,28 @@ public class GitChangeLogFinder {
 
         FileRepositoryBuilder repositoryBuilder = new FileRepositoryBuilder();
 
-        Repository repository = repositoryBuilder
+        try (Repository repository = repositoryBuilder
                 .setGitDir(repoPath.toFile())
                 .readEnvironment() // scan environment GIT_* variables
                 .findGitDir() // scan up the file system tree
                 .setMustExist(true)
-                .build();
+                .build()) {
 
-        Ref fromTag = getTagChecked(repository, artifactId, from);
-        Ref toTag = getTagChecked(repository, artifactId, to);
+            Ref fromTag = getTagChecked(repository, artifactId, from);
+            Ref toTag = getTagChecked(repository, artifactId, to);
 
-        Git git = Git.wrap(repository);
+            Git git = Git.wrap(repository);
 
-        fromTag = repository.getRefDatabase().peel(fromTag);
-        toTag = repository.getRefDatabase().peel(toTag);
+            fromTag = repository.getRefDatabase().peel(fromTag);
+            toTag = repository.getRefDatabase().peel(toTag);
 
-        List<String> commits = new ArrayList<>();
-        git.log()
-                .addRange(fromTag.getPeeledObjectId(), 
toTag.getPeeledObjectId())
-                .call()
-                .forEach(c -> commits.add(c.getShortMessage()));
-
-        return commits;
+            List<String> commits = new ArrayList<>();
+            git.log()
+                    .addRange(fromTag.getPeeledObjectId(), 
toTag.getPeeledObjectId())
+                    .call()
+                    .forEach(c -> commits.add(c.getShortMessage()));
+            return commits;
+        }
     }
 
     private Ref getTagChecked(Repository repository, String artifactId, String 
version) throws IOException {

Reply via email to