nscendoni commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/14#issuecomment-2772439483
> I started reviewing and had some initial comments but then saw the move of impl to spi and I stopped :-) > > I am usually very careful about exposing APIs, can you please explain why all of them need to be public and reusable? We may need to create additional abstractions to make sure they make sense to consumers. I agree. I plan to rollback the move of impl to spi as soon as I can split spi and implementation for sling-commons-crypto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
