nscendoni commented on PR #15: URL: https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/15#issuecomment-2934835544
> I think this is very close to being done. From my point of view there are only three issues to solve: > > * the cookie topic (important) I've pushed a change that works with only one encrypted cookie. I also refactored the OAuth Code to work with that. There are not anymore information passed in the state parameter. > * removal of unrelated formatting changes, e.g. adding empty lines, cleaning up whitespace,etc. This makes history much harder to track. Any formatting changes must come as a separate PR and we should do it by upgrading to the latest parent pom which enforces a code formatting standard. But let's do that after we merge this PR :-) I fixed the setting in my ide :-) > * the ITs leave untracked files in the project's base dir, please review the persistence code. Also the file name seems wrong (no extension) > > ``` > cookie-tokens14644194543422998595bin > cookie-tokens17544281903593273246bin > cookie-tokens401491827215654835bin > cookie-tokens5223146744397278699bin > cookie-tokens5292745495627831483bin > cookie-tokens5503793274250268725bin > cookie-tokens6559516317127871037bin > ``` I fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
