anchela commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/26#discussion_r2244919208
##########
src/main/java/org/apache/sling/auth/oauth_client/impl/SlingUserInfoProcessorImpl.java:
##########
@@ -67,6 +67,9 @@ public class SlingUserInfoProcessorImpl implements
UserInfoProcessor {
description = "Name of the claim in the ID Token or UserInfo
that contains the groups. "
+ "If not set, the default 'groups' is used")
String groupsClaimName() default "groups";
+
+ @AttributeDefinition(name = "connection", description = "OIDC
Connection Name")
Review Comment:
i checked again in the IDE. not sure if that impacts the auth-handler above.
but the return value of SlingUserInfoProcessorImpl.connection() is not
guarateed to be null without additional checks in the constructor or a default
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
